Skip to content

AdMob (#90): front end, choosing the revenue source on 2a #97

Closed

Description

@Lin1er

Owner: @Nabil-Aufa · Design: @AncungAulia · Branch: feat/admob-fe · Parent: #90 · Was blocked by: #93, done 2026-10-26 (both parts) · Start: now on the branch, pending @Lexirieru's go on #90 for merging before 2026-10-30 (otherwise after 2026-11-08) · Label: out-of-sow · Also blocked by: the relay issue

Let a creator choose where their revenue comes from on 2a: AdSense (websites) or AdMob (apps).

What

  1. A source choice on 2a.
    • The Google sign-in asks only for the chosen source's scope: adsense.readonly or admob.readonly, never both.
    • source is sent on POST /proofs.
  2. Copy names the source on the waiting, reading and offer screens.
  3. Failure panels.
    • A noAdmob panel, like noAdsense.
    • The relay error codes are unchanged. The kept job in sessionStorage records its source.
  4. Design. The board gets the choice and the new panel (@AncungAulia).
  5. e2e. The relay spec covers both sources.

Done when

The flow completes in the browser for both sources against the relay, with unit and e2e tests passing.


Working agreement

  1. One issue, one owner. 2. Branch per issue, named above, not the GitHub-suggested one. 3. MCP Stellar Raven for any Stellar/Soroban fact that gets written down. 4. Merge through PR review by Axel (PM); no self-merge. If an ACC has not arrived within two days on something already verified, merge and say so in the PR. 5. Deploys need evidence: contract address or tx hash on stellar.expert, recorded in docs/deployments.md. 6. Secrets live in .env, gitignored, chmod 600: never printed, never committed, never pasted into an issue or PR. Only public G… and C… addresses appear anywhere. 7. Issues, commits and PRs in English.

Activity

  1. added
    M3-appWeek 3 — proof relay and the creator front end
    out-of-sowNot an Instawards deliverable
    ready-to-devUnblocked: development can start on the issue's branch
    and removed
    M3-appWeek 3 — proof relay and the creator front end
    on Oct 25, 2026
  2. Lin1er commented on Oct 26, 2026

    @Lin1er
    CollaboratorAuthor

    @Nabil-Aufa the relay side of AdMob is in draft as #100, so the API shape is fixed enough to build against (docs/api.md):

  3. added 6 commits that reference this issue on Oct 29, 2026
  4. added 2 commits that reference this issue on Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

out-of-sowNot an Instawards deliverableready-to-devUnblocked: development can start on the issue's branch

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions