You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
AdMob (#90): front end, choosing the revenue source on 2a #97
Owner:@Nabil-Aufa · Design:@AncungAulia · Branch:feat/admob-fe · Parent:#90 · Was blocked by:#93, done 2026-10-26 (both parts) · Start: now on the branch, pending @Lexirieru's go on #90 for merging before 2026-10-30 (otherwise after 2026-11-08) · Label:out-of-sow · Also blocked by: the relay issue
Let a creator choose where their revenue comes from on 2a: AdSense (websites) or AdMob (apps).
What
A source choice on 2a.
The Google sign-in asks only for the chosen source's scope: adsense.readonly or admob.readonly, never both.
source is sent on POST /proofs.
Copy names the source on the waiting, reading and offer screens.
Failure panels.
A noAdmob panel, like noAdsense.
The relay error codes are unchanged. The kept job in sessionStorage records its source.
Design. The board gets the choice and the new panel (@AncungAulia).
e2e. The relay spec covers both sources.
Done when
The flow completes in the browser for both sources against the relay, with unit and e2e tests passing.
Working agreement
One issue, one owner. 2. Branch per issue, named above, not the GitHub-suggested one. 3. MCP Stellar Raven for any Stellar/Soroban fact that gets written down. 4. Merge through PR review by Axel (PM); no self-merge. If an ACC has not arrived within two days on something already verified, merge and say so in the PR. 5. Deploys need evidence: contract address or tx hash on stellar.expert, recorded in docs/deployments.md. 6. Secrets live in .env, gitignored, chmod 600: never printed, never committed, never pasted into an issue or PR. Only public G… and C… addresses appear anywhere. 7. Issues, commits and PRs in English.
@Nabil-Aufa the relay side of AdMob is in draft as #100, so the API shape is fixed enough to build against (docs/api.md):
POST /proofs takes source: "admob". Without it, it is AdSense, as today. The token needs admob.readonly.
An AdMob request adds "source": "admob" and "revenueMicros" (the signed figure, in micros). revenueUsd is then an exact decimal, for display only. What request_advance takes for AdMob is AdMob (#90): contract, a revenue source in the template, the nullifier and sizing #94's call, so keep the contract call behind one function until it lands.
At zero, the job fails with provider, and the message says AdMob reports no earnings for the window. Worth its own copy, like noAdsense.
Activity
Lin1er commentedon Oct 26, 2026
@Nabil-Aufa the relay side of AdMob is in draft as #100, so the API shape is fixed enough to build against (docs/api.md):
POST /proofstakessource: "admob". Without it, it is AdSense, as today. The token needsadmob.readonly.requestadds"source": "admob"and"revenueMicros"(the signed figure, in micros).revenueUsdis then an exact decimal, for display only. Whatrequest_advancetakes for AdMob is AdMob (#90): contract, a revenue source in the template, the nullifier and sizing #94's call, so keep the contract call behind one function until it lands.provider, and the message says AdMob reports no earnings for the window. Worth its own copy, likenoAdsense.admob.readonlyon our client until Publish the Google OAuth consent screen: domain verification, policy links, review #86 is through (AdMob (#90): consent screen and privacy policy, the second scope #98). Until then, the source picker and copy can be built against the mock.feat(#97): choose AdSense or AdMob on 2a, and prove the chosen one
test(#97): e2e for proving AdMob, and stack the source tiles on the n…
fix(#97): the chosen source's tile is highlighted from state, and e2e…
fix(#97): a resumed AdMob proof stays AdMob, and every screen of it s…
test(#97): wait for the second proof before reading what it sent
feat(#97): lead request_advance and nullifier_for with the revenue so…
feat(#97): choose AdSense or AdMob on 2a, and prove the chosen one (#104
fix(#97): Advance details name AdMob for an AdMob advance, from the A…