Repository navigation
Open
Labels
out-of-sowNot an Instawards deliverableNot an Instawards deliverableready-to-devUnblocked: development can start on the issue's branchUnblocked: development can start on the issue's branch
Description
Owners: @AncungAulia (privacy policy, terms) and @Lin1er (OAuth client) · Branch: docs/admob-consent · Parent: #90 · Was blocked by: #93, done 2026-10-26 (both parts) · Start: now on the branch, pending @Lexirieru's go on #90 for merging before 2026-10-30 (otherwise after 2026-11-08) · Label: out-of-sow · Also after: #86 published
Add admob.readonly to the Google consent screen and the legal pages.
Lead time nobody controls
admob.readonly may restart Google's sensitive-scope verification. So:
- Do not add the scope to the OAuth client until Publish the Google OAuth consent screen: domain verification, policy links, review #86 is published. Adding it during Publish the Google OAuth consent screen: domain verification, policy links, review #86's review risks resetting that review.
- Start this issue first among the post-SOW ones, as soon as Publish the Google OAuth consent screen: domain verification, policy links, review #86 is published, because Google's review time is outside our control.
- The spike (Spike (#90): zkFetch POST body signing, and AdMob's response at zero and above #93 part 2) does not need the scope on our client: it uses the OAuth 2.0 Playground, which has its own client.
What
- OAuth client (@Lin1er). Add
admob.readonlyin Data Access, write the scope justification, and resubmit for verification if Google asks. /privacy(@AncungAulia).- The second scope, what is read (AdMob estimated earnings over three months, nothing else), and what becomes public (the same four fields).
content/legal.test.tschecks the scopes againstbe/, so it fails until both sides match.
/terms. "AdSense or AdMob account" where ownership is required.
Done when
The consent screen lists both scopes, is published, and verification (if required) has passed. The legal pages are updated and live.
Working agreement
- One issue, one owner. 2. Branch per issue, named above, not the GitHub-suggested one. 3. MCP Stellar Raven for any Stellar/Soroban fact that gets written down. 4. Merge through PR review by Axel (PM); no self-merge. If an ACC has not arrived within two days on something already verified, merge and say so in the PR. 5. Deploys need evidence: contract address or tx hash on stellar.expert, recorded in
docs/deployments.md. 6. Secrets live in.env, gitignored,chmod 600: never printed, never committed, never pasted into an issue or PR. Only publicG…andC…addresses appear anywhere. 7. Issues, commits and PRs in English.
Metadata
Metadata
Assignees
Labels
out-of-sowNot an Instawards deliverableNot an Instawards deliverableready-to-devUnblocked: development can start on the issue's branchUnblocked: development can start on the issue's branch
Activity
Lin1er commentedon Oct 27, 2026
Unblocked: #86 is published (2026-10-27).
admob.readonlyin Data Access now./privacynames both scopes, says only the chosen one is asked for, and says an AdMob figure is public to the millionth of a dollar./termssays "AdSense or AdMob account".Order: submit the scope for verification only once #105's
/privacyis live, because Google reviews the scope against that page. Merging #105 waits on @Lexirieru's go on #90, like the rest of the AdMob work.Lin1er commentedon Oct 27, 2026
OAuth client half, done 2026-10-27:
https://www.googleapis.com/auth/admob.readonlyis in Data Access, next toadsense.readonly, with its justification.Not submitted for verification yet. Submitting waits for #105's
/privacyto be live, because Google reviews the scope against it. Until then a sign-in for AdMob works on the published screen, past the "unverified app" warning.Left on this issue: #105 (legal pages, @AncungAulia's wording), then submit the scope.
docs(#98): the privacy policy and terms cover AdMob, the second scope