Skip to content

feat(#97): name a Google account that earned nothing, for AdSense and AdMob - #109

Open
Nabil-Aufa wants to merge 4 commits into
mainfrom
feat/relay-empty-panel
Open

Nabil-Aufa wants to merge 4 commits into
mainfrom
feat/relay-empty-panel

Conversation

@Nabil-Aufa

Copy link
Copy Markdown
Collaborator

The relay answers a failed job with empty when the Google account earned nothing in the three months (docs/api.md, merged in #100). The front end did not know the code and showed "We could not finish your proof / Nothing was charged. Try again in a few minutes", which trying again cannot fix: it proves the same months.

What changed

Commit What
9bb4e45 empty joins the relay codes. It maps per source to its own panel, "No AdSense revenue to prove" or "No AdMob revenue to prove", with the picture and single Back of "Not enough revenue yet". Back returns to 2a on the same source. Unit tests for the mapping and the relay client, and e2e for both sources on the relay build.
5bb0256 Fixes from a strict review: the body says what to do next, and e2e pins the panel's picture and words.
219fce2 Pins both panels' whole words in unit tests, and drops a clause that sounded internal.
a1bd2ed Draws both panels on the board, see below.

The words:

Panel Title Body
AdSense No AdSense revenue to prove We found no AdSense revenue in the last three complete months. If you earn with AdMob, go back and prove that instead. Nothing was charged.
AdMob No AdMob revenue to prove We found no AdMob revenue in the last three complete months. If you earn with AdSense, go back and prove that instead. Nothing was charged.

Only Back, no "Prove again": proving again reads the same months, and the relay refuses empty before the attestor.

For the board (@AncungAulia)

I drew both panels on "Prove and accept / States and interactions" myself (a1bd2ed), so the board stays the single source:

  • Row 3 "When it does not work" gains "No AdSense revenue" and "No AdMob revenue", copied from "Too small to offer": the same 400px panel, the No advance yet picture and a single full-width Back. Only the words differ.
  • Row 5 "Every message, word for word" gains both rows, under "We could not read your revenue".

Change or reject anything there, and the code will follow the board. One note from the review: the body runs 4 lines where the board's run 2 to 3. If you want 3, "Nothing was charged" is the sentence to shorten or drop.

Checked

  • Lint and typecheck are clean. 206 unit tests pass.
  • Playwright: 250 pass, 24 skipped, both builds, including the two new e2e tests on desktop and mobile.
  • A strict review passed on the third round: Playwright in Chrome at 1440 and 390 (focus on the panel's title, no horizontal scroll, Back fully visible, still on step 1), and the structure against the board's "Too small to offer" panel in Pencil. Real Chrome could not reach the panel without a stubbed Stellar RPC, so both panels were checked in Playwright only.

🤖 Generated with Claude Code

Nabil-Aufa and others added 4 commits October 30, 2026 22:35
… AdMob

The relay answers `empty` when the three months hold no earnings (#100).
The front end read it as an unknown code and showed "We could not finish
your proof ... Try again in a few minutes", which trying again cannot fix.

`empty` now has its own panel per source, "No AdSense revenue to prove" and
"No AdMob revenue to prove", with the picture and the single Back of "Not
enough revenue yet". Back returns to 2a on the same source, where the
creator can pick the other one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e and words in e2e

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… that sounded internal

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…states board

"When it does not work" gains "No AdSense revenue" and "No AdMob revenue",
copied from "Too small to offer": the same 400px panel, the No advance yet
picture and a single Back. "Every message, word for word" gains both rows,
with the words the front end shows.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Nabil-Aufa
Nabil-Aufa requested a review from Lexirieru October 30, 2026 16:21
@vercel

vercel Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
forepay Ready Ready Preview Oct 30, 2026 4:22pm UTC
forepay-vue5 Ready Ready Preview Oct 30, 2026 4:22pm UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant