Repository navigation
feat(#97): name a Google account that earned nothing, for AdSense and AdMob - #109
Open
Nabil-Aufa wants to merge 4 commits into
Open
Nabil-Aufa wants to merge 4 commits into
Nabil-Aufa wants to merge 4 commits into
Conversation
… AdMob The relay answers `empty` when the three months hold no earnings (#100). The front end read it as an unknown code and showed "We could not finish your proof ... Try again in a few minutes", which trying again cannot fix. `empty` now has its own panel per source, "No AdSense revenue to prove" and "No AdMob revenue to prove", with the picture and the single Back of "Not enough revenue yet". Back returns to 2a on the same source, where the creator can pick the other one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e and words in e2e Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… that sounded internal Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…states board "When it does not work" gains "No AdSense revenue" and "No AdMob revenue", copied from "Too small to offer": the same 400px panel, the No advance yet picture and a single Back. "Every message, word for word" gains both rows, with the words the front end shows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The relay answers a failed job with
emptywhen the Google account earned nothing in the three months (docs/api.md, merged in #100). The front end did not know the code and showed "We could not finish your proof / Nothing was charged. Try again in a few minutes", which trying again cannot fix: it proves the same months.What changed
9bb4e45emptyjoins the relay codes. It maps per source to its own panel, "No AdSense revenue to prove" or "No AdMob revenue to prove", with the picture and single Back of "Not enough revenue yet". Back returns to 2a on the same source. Unit tests for the mapping and the relay client, and e2e for both sources on the relay build.5bb0256219fce2a1bd2edThe words:
Only Back, no "Prove again": proving again reads the same months, and the relay refuses
emptybefore the attestor.For the board (@AncungAulia)
I drew both panels on "Prove and accept / States and interactions" myself (
a1bd2ed), so the board stays the single source:Change or reject anything there, and the code will follow the board. One note from the review: the body runs 4 lines where the board's run 2 to 3. If you want 3, "Nothing was charged" is the sentence to shorten or drop.
Checked
🤖 Generated with Claude Code