Repository navigation
Design: add the Input amount role to the type scale - #84
Merged
Merged
Conversation
Section 08's type scale gets an Input amount role, 32 / 36 / 36 (phone / tablet / desktop), for the amount typed in a field such as the 3a repay input. Figure read too small on a phone and Amount was too large for the 320 side column. Answers the question on #71. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Nabil-Aufa
added a commit
that referenced
this pull request
Oct 20, 2026
@AncungAulia's answer on #71, with the role added to section 08 in #84: the amount typed in a field. On a phone it reads larger than the balance's unit, and from a tablet it is the 36 the frames draw, which still fits the 320 side column beside the USDC and Max chips. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Nabil-Aufa
added a commit
that referenced
this pull request
Oct 23, 2026
* fix(#70): give the shells the section 08 breakpoints Tablet from 768: the top nav and no tab bar, a 32px gutter and one column up to 640. Desktop from 1024: content up to 1200, centred, a 40px gutter (80 from 1280). The onboarding top bar and its centred column start at 768 too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(#70): add the section 08 type roles, and let panel buttons wrap when they do not fit text-hero, text-amount, text-page-title, text-card-title, text-body and text-small step at 768 and 1024, in rem. They replace the unused single-size scale. tailwind-merge learns they are font sizes. An error panel's two buttons wrap to a second row when they do not fit, the main one on top. When they must stack under 768 is settled in a later commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(#70): lay out 2a for the tablet and keep it inside the window from 1024 Tablet: the desktop stepper, the Prove card as a row with a 200 illustration, the two lists one under the other, and the wallet and rule cards side by side under it, as frame 2a Tablet draws. Desktop: a 320 side column (the 360 from 1200 takes effect in a later fix), the lists side by side only when the text column has room, and every list item free to wrap. The page and card titles use the type roles. The rule's placeholder is now bars in the shape of the sentence, so the card keeps its height however many lines the sentence takes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(#70): lay out 2b for the tablet and let its figures wrap on a narrow phone Tablet: the desktop offer card and breakdown labels, with If you accept, the timer and both buttons under them, as frame 2b Tablet draws. Desktop: the side column is 320 (360 from 1200 in a later fix). The offer uses the hero amount role (56, 72, 88). A breakdown row with no room puts its value under its label, so nothing spills at 320. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(#70): give onboarding, 2c, 2d and the shared parts their tablet form From 768 the onboarding steps, Sign and Funds received use the centred column and sizes the desktop has, the wallet chip shows its chevron, the wallet picker and the repayment approval are centred dialogs rather than sheets. Step titles use the page title role (28, 36, 44) and Funds received the amount role (48, 56, 64); the checking skeleton follows the title's height. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(#70): lay out 3a for the tablet and let its rows and chips wrap Tablet: the desktop balance card, quick action labels and View contract, with the repay form, transactions, advance details and the ledger note in one column, as frame 3a Tablet draws. Desktop: the side column is 320 (360 from 1200 in a later fix). The balance uses the hero amount role. A transaction's date moves under its status on a narrow phone, a quick action label wraps rather than being cut, and a repay chip with no room moves to a second row (a later commit gives the chips equal widths). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(#70): lay out 3b for the tablet Tablet: the desktop summary tiles, eyebrow and ledger note, as frame 3b Tablet draws. The title uses the page title role. On a narrow phone the tiles no longer spill: a later commit lets them keep their size and wrap, as section 08 asks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(#70): check every app screen at the six widths of section 08 Onboarding (1a, 1b, no wallet, 1c), 2a, 2b, a two-button panel, 3a and 3b, each at 320, 375, 768, 1024, 1280 and 1440: the page is no wider than the window, nothing is wider than its own box, and no label runs past its content box (centred text spills on both sides, which scrollWidth does not count). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(#70): build Repayment and History before the first advance as drawn The No advance yet card is 400 wide with 24 padding, the full column on a phone, and sits 48 under the title from a tablet up, as the four No advance yet frames draw. The layout check covers both pages in that state. Until #16 answers, the fixture client takes forepay.mock.ledger: none, active (the default), repaid or error, to try each ledger state by hand. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(#70): word a failed row as #16 defines it, with its receipt A failed transaction reached the ledger and failed there: the network fee was spent and no USDC moved, so "not charged" and "No transaction" were wrong. The row now says "Failed, no USDC moved" ("Failed" on a phone) and links its receipt like every other row. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(#70): say where 2a's revenue window really comes from Not the contract's claim template: it is the input of our own flow, what the #17 relay asks AdSense for, as @Lexirieru explained in the #57 review. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(#70): end at once on a send refused after leaving /advance The send's answer went to the screen the creator had left, which dropped it, so the screen they came back to waited two minutes on a transaction that never reached a ledger. A refusal is now remembered with the pending advance, and a screen already waiting on it is told: either way "The transaction did not go through" shows at once, and Try again sends it. The RPC stub no longer reports a request_advance still being sent, or refused, as landed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(#70): widen the side column to 360 from a 1200 window, as claimed min-[1200px]: sorted before lg: in the built CSS, so the column stayed 320 at every width. A wide breakpoint (75rem) sorts after lg. The layout check now measures the content box at 768 to 1440 and the side column at 1199 and 1200. In the 360 column the rule card's sentence takes three lines, so its loading bars now stand on invisible words with no figure that render as wide as the usual sentence, keeping the card's height at every width. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(#70): keep the wordmark whole in the top nav from 768 The row needs 745 for the wordmark, tabs and chips as the 834 frame draws them, and a 768 window leaves 704, so the wordmark shrank to 109. Nothing in the row shrinks now: below 834 the tabs take 10 of side padding instead of 20, from 834 they are as drawn, 12 apart. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(#70): stack a panel's two buttons under 768 unless the pair fits at 320 Wrapping by the current width put "Allow USDC" and "Not now", or "Get Freighter" and "Back", side by side at 375. Section 08 decides per pair: under 768 they stack, main first, and only "Try again" or "Prove again" with "Back", which fit at 320, keep one row. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(#70): give the repay chips equal widths and the balance circles their drawn place The chips were sized by their labels (69, 70, 117). They now share one row equally where Full amount fits three times over; otherwise Full amount moves to a second row at the same width, as section 08 asks of chips. The balance card's circles are anchored 560 and 610 from the left, as every 3a frame draws them, rather than from the right, which only matched an 824 card. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(#70): let 2a's side cards keep their own heights on a tablet Side by side under the Prove card they stretched to the taller one; frame 2a Tablet draws the rule card shorter than the wallet card. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(#70): list the forepay.mock.ledger states in the README Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(#70): let a transaction's title wrap instead of cutting it at 320 "Repayment" read "Repayme…" and "Advance received" read "Advance …": section 08 keeps the ellipsis for a line that matters more than its words. The title column keeps at least its longest word, so a title wraps between words; on a narrow phone the amount gives way instead, its unit moving under the figure. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(#70): let the History figure tiles keep their size and wrap at 320 Section 08: chips and figure tiles keep their size and move to a new line. The tiles share equal grid columns at least 98 wide on a phone (the label on one line, the unit under the figure as frame 3b Mobile draws it), so at 320 the third moves to a second row at the same width; from 375 the three share one row. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(#70): walk the six widths for proving, sending, 2d and a loading ledger too Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(#70): show the pointer on everything clickable, and not-allowed when disabled Tailwind 4's preflight gives buttons the default cursor, so every button showed the arrow while links showed the pointer. One base rule in globals.css, from @AncungAulia's review, covers buttons, menu items, tabs and labels; the wallet menu items drop their cursor-default. Buttons and quick actions no longer turn pointer events off when disabled (a disabled button ignores clicks anyway), so the not-allowed cursor shows over them. The e2e reads the cursor of what is really under the pointer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(#21): find the new repayment's Today in its own row A fixture row is dated 20 Oct 2026, so on that day the list held two Todays and the check failed in strict mode. It now looks in the row of the repayment just made. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(#70): put every amount's unit under its figure below 360, so the column stays even At 320 "−20.00 USDC" broke onto two lines while "−10.00 USDC" in the next row did not (@AncungAulia's review). An amount now carries its unit apart: under 360, where the longest amount no longer fits, every row puts USDC under the figure; from 360 it sits beside it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(#70): set the touched screens' type in the section 08 roles @AncungAulia's answer on #71: the roles win, and drawn in-between sizes take the nearest role. Card, panel, dialog and empty-state titles take Card title (20, 22, 24); sentences and rows take Body (16); labels, statuses, dates, chips, notes and links take Small (13, 13, 14). A new Figure role (20, 28, 32) sets the History tiles, the breakdown's Your advance and the repay amount input. A unit beside a figure keeps its own weight and drops to Small next to a Figure. No pixel font size is left in the app. The checking skeleton follows the new body height. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(#70): keep a disabled button, quick action or chip still on hover and press Since disabled buttons stopped turning pointer events off (so the not-allowed cursor shows), their plain hover: and active: colours applied to them too: a disabled Repay tile or 25% chip turned grey under the pointer. Hover and pressed colours now apply only while the control can be used (not-disabled:, which links drawn as buttons match too). The e2e hovers and presses each disabled control on a fully repaid advance and checks a link tile still answers a hover. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(#70): set the repay amount in the Input amount role (32, 36, 36) @AncungAulia's answer on #71, with the role added to section 08 in #84: the amount typed in a field. On a phone it reads larger than the balance's unit, and from a tablet it is the 36 the frames draw, which still fits the 320 side column beside the USDC and Max chips. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(#70): never cut a typed repay amount; the chips and a long label wrap instead With the Input amount role, "100.00" was cut to an ellipsis at 320 and in the 320 side column from 1024 to 1199. The amount field is now as wide as what was typed, and when it and the USDC and Max chips no longer share the row, the chips move under it. The full-width repay action wraps a long label ("Repay 60.00 USDC instead") rather than run into its padding at 320. So that an uncut amount can never outgrow its field, the field takes no zero before another digit and a whole part of at most 99, or what is left to repay when that is more (60 left: up to 99, so typing past it still shows "Only ... left"; 100 left: up to 100, never 101 or a wide 800), and with three digits six decimals at most. The limit is on the value because digits differ in width ("1" narrowest, "0" widest in Geist). The widest amounts it allows, "80.0000000" and "100.000000", fit the field at 320 and in the side column. The e2e types them key by key and measures them against the field's border. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(#70): keep any .next-* build output out of lint A dev server pointed at another build folder (NEXT_DIST_DIR) left one behind and failed lint. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Nabil-Aufa <181296848+Nabil-Aufa@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Section 08 "Layout and responsive" in
docs/design/forepay.pen: the type scale gets an Input amount role, 32 / 36 / 36 (phone / tablet / desktop), for the amount typed in a field, such as the 3a repay input.Figure (20 / 28 / 32) read smaller than the 22 "USDC" beside the balance on a phone, and Amount (48 / 56 / 64) was too large for the 320 side column at 1024. Answers the question on #71.
Design only, no code.
🤖 Generated with Claude Code