The logs command doesn't recognize slashes in script path. It should.#786
Open
dirksen wants to merge 1 commit intoforeversd:masterfrom
dirksen:master
Open
The logs command doesn't recognize slashes in script path. It should.#786dirksen wants to merge 1 commit intoforeversd:masterfrom dirksen:master
dirksen wants to merge 1 commit intoforeversd:masterfrom
dirksen:master
Conversation
Contributor
|
Thank you for your contribution! Could you please add tests for this change that would ensure original use-cases still work the same way? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I often start my node servers using absolute path, like:
But the logs command doesn't recognize slashes in the script path, and this fails:
This patch should fix this problem