Skip to content

refactor(store): move attempts snapshots domains into modules - #118

Merged
freezscholte merged 1 commit into
mainfrom
codex/ner-378-store-snapshots-attempts-domain
Jul 5, 2026
Merged

freezscholte merged 1 commit into
mainfrom
codex/ner-378-store-snapshots-attempts-domain

Conversation

@freezscholte

@freezscholte freezscholte commented Jul 5, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Move attempt lifecycle, workspace paths/markers, attempt resolution/list/show/attach, and materialization helpers into crates/forge-store/src/attempts.rs.
  • Move snapshot save/restore/checkout/undo, expected content refs, latest snapshot helpers, and native history log/head walking into crates/forge-store/src/snapshots.rs.
  • Preserve existing public API paths through lib.rs re-exports and keep cross-domain helpers crate-private.
  • Lower the store lib.rs line-count cap from 5,962 to 4,624 and update ADR-0001 with the NER-378 audit note.

Verification

  • rtk cargo check -p forge-store
  • scripts/check-rust-line-count.sh
  • rtk cargo test -p forge-cli --test forge_start_save
  • rtk cargo test -p forge-cli --test forge_attempts
  • rtk cargo test -p forge-cli --test forge_native_history
  • rtk cargo test -p forge-cli --test forge_propose_check
  • rtk cargo test -p forge-cli --test forge_review_surface
  • rtk cargo test -p forge-cli --test forge_compare
  • rtk cargo test -p forge-cli --test forge_conflict_set
  • rtk cargo test -p forge-cli --test forge_native_merge
  • rtk cargo fmt --all --check
  • rtk cargo test --workspace — 603 passed across 61 suites
  • rtk cargo clippy --workspace --all-targets -- -D warnings
  • rtk bash scripts/ci.sh — PASS=95 FAIL=0

Fixes NER-378.
Related NER-371.


View with Codesmith Autofix with Codesmith
Need help on this PR? Tag /codesmith with what you need. Autofix is disabled.

@freezscholte
freezscholte merged commit c364555 into main Jul 5, 2026
1 check passed
@freezscholte
freezscholte deleted the codex/ner-378-store-snapshots-attempts-domain branch July 5, 2026 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant