fix: keep the check code on the Done screen; make release APKs reproducible on F-Droid - #25
Merged
Merged
Conversation
The check code was cleared as soon as finishEnrolment ran, before the owner had necessarily finished comparing it with Sapwood or the board's own card. It now stays labelled and visible on the Done screen, with a reminder of what it should match, until the owner leaves.
F-Droid's reproducible-build check for 0.5.0 failed on one file: META-INF/version-control-info.textproto recorded NO_VALID_GIT_FOUND in the published APK (built from a worktree) and the commit in F-Droid's clone. Turning vcsInfo off makes both builds match whatever checkout they come from. Also words the Done screen's check code hint as matching the board and Sapwood, since both show it.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small changes for 0.7.1.
META-INF/version-control-info.textproto:NO_VALID_GIT_FOUNDin the published APK, which was built from a git worktree, against the commit in F-Droid's clone.vcsInfo.include = falseon the release build type removes that file, and a local release build confirms it's gone. 0.5.0 to 0.7.0 can't be fixed after the fact. The next tagged release should pass.JVM unit tests: 271 passing. Not installed on a phone.