Repository navigation
fix: schedule quiet wraps at their slot deadlines - #1
Merged
Merged
Conversation
TheCryptoDonkey
marked this pull request as ready for review
September 10, 2026 00:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QuietTransport could skip an entire slot when its random send offset fell after the last fixed timer poll. Short intervals were especially affected: polling once per interval kept the same phase and could postpone queued messages for many slots while also omitting fillers.
Schedule the selected deadline directly, recheck long waits for clock changes, and retry refused publishes after one second. Preserve the custom scheduler seam, non-overlapping writes, same-wrap retry and no catch-up bursts. No event format, key derivation or dependency changes.
Validation: three deterministic default-timer regressions fail before the fix and pass afterwards, covering eight-second and five-minute slots plus same-wrap retry. All 82 tests pass locally on Node 22/24; hosted CI is green on both versions. Type checking, package build and a cold-install API smoke pass. An independent consumer checkout tested the packed candidate in Chromium, Firefox and WebKit on Linux CI; all passed.