fix: accept Lightning node ids in get_info; honest outcome docs; 0.1.8 - #12
Merged
Merged
Conversation
WALLET_ERROR was left out of the outcome guidance. Only an explicit refusal is definite; INTERNAL, OTHER and unknown codes must be reconciled. UNSUPPORTED_EXTENSION joins the pre-publication list, and the site's Silence row now names invalid responses too.
Every demo error read "rejected by nwc-kit" in red, including a pay_invoice timeout or invalid response after publication. Those now read "outcome unknown: reconcile before retrying" in amber. Pre-publication failures stay rejections and explicit wallet refusals are labelled as the wallet's.
result_type is inside the ciphertext, so it cannot be checked before decryption. inspectNwcConnection() returns no budget hints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-announcement fixes from the audit.
getInfo()accepted only 32-byte hex pubkeys, so it rejected the 33-byte node id LND, Alby Hub and nwc-lnd-bridge return.INTERNAL,OTHERand unknown codes are ambiguous.