feat: a simple, bold Device screen - #145
Merged
Merged
Conversation
…ctions The Device screen stacked eleven sections of equal weight with diagnostics and long prose burying the things that need doing. Add a "Your signer" summary of bold status rows (worst first), each with one button that opens and scrolls to the matching section, now a closed-by-default disclosure. Diagnostics and lengthy explanations move into the sections or a nested "Why?" disclosure; warnings tied to an imminent action stay visible. Extract the summary-row derivation to lib/device-summary.ts (unit tested) and give Connectivity, OtaUpdate and Backup a heading prop so their titles can be suppressed when nested under a section summary.
…n state
Review feedback on the "Your signer" summary:
- each row now leads with a fixed-width, bold concern label ("Firmware",
"After a power cut", "Backup", "Connection", "Storage"), so the state text
can read plainly instead of repeating what it's about
- the connection row no longer repeats a storage warning that already has
its own row; it now names only a crash, fragmented memory or a recovery
restart
- backup and after-a-power-cut gain a neutral grey "unknown" dot (a new
SummaryDot value) instead of reading green when nothing is actually known
yet; green is reserved for a proven good state
- at 480px and below the row stacks: dot+label, then the state text, then a
full-width button, so the dot is never left alone on its own line
- the "Your signer" heading is now bigger and bolder than a section summary
Widened the summary-row label column so "After a power cut" doesn't clip,
and moved the mobile tab bar's clearance check into a dedicated bottom-of-
page screenshot to confirm the danger zone isn't hidden under it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Device screen stacked eleven sections at the same weight, with diagnostics first and the things to act on buried in paragraphs.
src/lib/device-summary.ts, with 18 tests.Tests: svelte-check clean, vitest 1070/1070, chromium e2e 31/31, build OK.