Conversation
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
`just test` was an empty recipe, so ci.yaml's Test step ran nothing and
go-test-platforms.yml was the only thing testing this repo. Wire test to
the shared unit and race recipes plus a 386 leg, and add bench.
The 386 leg turned out to be broken: a WriterConfig{DictCap: 1 << 40}
test case does not compile where int is 32 bits, so that job had been
failing since it was added. A capacity above MaxDictCap (1<<32-1) is
representable only on 64-bit, so guard the case and use math.MaxInt.
Drop go-test-platforms.yml (ci.yaml's matrix covers more, and now runs
the 386 leg too) and codeql.yml: the baseline SAST posture is golangci's
gosec/staticcheck plus govulncheck per GOOS, and limen wants CodeQL as
default setup opted into via limen.yaml, not a workflow pinned by tag.
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.