add architect hook installers #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: Add built-in architect hook commands for Claude/Codex/Gemini and require lint in the workflow. Solution: Extend the embedded architect helper with hook subcommands that update configs idempotently. Solution: Update Gemini hook wrapper to prefer architect notify when available. Solution: Document the installer flow in AI integration docs and note lint in CLAUDE.md.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d53647617d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR adds hook installer subcommands to the embedded architect shell helper, enabling users to automatically configure Claude, Codex, and Gemini CLI tools for Architect notifications. The installer updates config files only when hooks are missing, preserving the existing notify behavior.
Changes:
- Extended the embedded Python
architectcommand withhook claude|codex|geminisubcommands that intelligently update tool configs - Updated the Gemini hook wrapper to prefer the built-in
architect notifycommand when available - Documented the installer workflow and added
just lintto the required build steps
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/shell.zig | Added architect_command_script with hook installer logic and PATH injection for the architect command |
| scripts/architect_hook_gemini.py | Updated to prefer architect command over direct script invocation |
| docs/architecture.md | Documented the architect command availability in shell PATH |
| docs/ai-integration.md | Added hook installer instructions and clarified when to use the built-in command vs. scripts |
| README.md | Updated documentation reference to mention the new architect commands |
| CLAUDE.md | Added just lint to the required build and test steps |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Issue: architect hook gemini wrote literal \n in JSON and architect notify did not light up. Solution: write real newlines in hook installer output and notify payloads. Solution: document restarting terminals after upgrades for refreshed helper scripts.
Issue: Review comments requested narrowing exception handling in embedded installer script. Solution: Catch ImportError for tomllib import, JSONDecodeError for JSON parsing, and TOMLDecodeError for tomllib parsing.
Issue: Users may already have Codex notify configured and need safe updates with backups. Solution: Add notify chaining via wrapper and timestamped backups for settings updates.
Issue: Users asked to replace Codex notify while warning and printing backup names. Solution: Always overwrite notify, emit warning on existing config, and print timestamped backup path.
Issue: Codex notify line was appended under the last table instead of root. Solution: Remove existing notify lines and insert the new notify before the first table header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: