Conversation
…l precision The previous bucket boundaries (0.1, 0.5, 1.0, 5.0, 10.0 seconds) were too coarse for the actual reconcile durations which average around 0.9ms. All values were falling into the first bucket (< 0.1s), making the histogram uninformative. New buckets provide better granularity: - 0.001s (1ms), 0.005s (5ms), 0.01s (10ms), 0.025s (25ms), 0.05s (50ms) - 0.1s (100ms), 0.25s (250ms), 0.5s (500ms), 1.0s, 2.5s, 5.0s, 10.0s This captures the typical sub-10ms reconcile times while still tracking outliers in the second range. Resolves: #54
|
@forkline we don't need so many values. Reduce the number of ranges in the bucket, do it in a useful way, select the most relevant for the operations |
Simplified bucket boundaries from 12 to 5 values: - 0.001s (1ms): typical reconcile time (~0.9ms avg) - 0.01s (10ms): slightly slower operations - 0.1s (100ms): slow reconciles - 1.0s: significant outliers - 10.0s: extreme cases This maintains useful granularity for monitoring while reducing cardinality.
Author
There was a problem hiding this comment.
Done. Reduced histogram buckets from 12 to 5 essential values:
- 0.001s (1ms): Typical reconcile time (~0.9ms average)
- 0.01s (10ms): Slightly slower operations (10x typical)
- 0.1s (100ms): Slow reconciles (100x typical)
- 1.0s: Significant outliers (1000x typical)
- 10.0s: Extreme cases
This provides a clean logarithmic distribution that captures the full performance range while minimizing cardinality.
Author
|
✅ CI Fix Applied I've pushed a fix for the CI failure. The changes should trigger a new CI run. Commit: Waiting for CI to re-run... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The current histogram buckets were not useful for monitoring because all reconcile operations completed in less than 0.1 seconds (the smallest bucket). This made it impossible to observe performance variations in the typical reconcile duration range.
Example metrics showed:
All values were in the first bucket, with an average of ~0.9ms.
Solution
New bucket boundaries in seconds:
This captures the typical sub-10ms reconcile times while still tracking potential outliers in the second range.
Resolves: #54