Skip to content

ci(gate-attestation): waive release-please PRs branch-shaped, not author-shaped - #10

Merged
forkwright merged 1 commit into
mainfrom
fix/gate-attestation-rp-branch-waiver
Jul 8, 2026
Merged

forkwright merged 1 commit into
mainfrom
fix/gate-attestation-rp-branch-waiver

Conversation

@forkwright

Copy link
Copy Markdown
Owner

Summary

The reusable gate-attestation waives release-please by author login (release-please[bot]), but release-please running under GITHUB_TOKEN authors PRs as github-actions[bot] — the waiver never matches, so every library-repo release PR fails with "No Gate-Passed trailer found" (observed on heurema #5 / koinon #9 / epitelesis #8, 2026-07-08; epitelesis is hard-blocked because protection requires the check).

Change

Add a branch-shaped waiver — startsWith(github.head_ref, 'release-please--branches--') — alongside the author waivers, mirroring kanon's inline gate-attestation and its rationale: the author varies across token setups (GITHUB_TOKEN today, PAT later per kanon#1092), the branch pattern does not. Release-PR content is generated version bumps; its real verification is the live deny/audit/osv checks, which all pass on the affected PRs.

Risk

A human pushing a branch literally named release-please--branches--* would skip attestation — same accepted risk kanon's inline version documents.

…hor-shaped

The reusable waived release-please by author login (release-please[bot]), but
RP running under GITHUB_TOKEN authors its PRs as github-actions[bot] — the
waiver never matched, so every library-repo release PR failed gate-attestation
("No Gate-Passed trailer found"). Waive by head-ref pattern
(release-please--branches--*) alongside the author waivers: the author varies
across token setups, the branch pattern does not. Mirrors kanon's inline
gate-attestation, which learned this the same way.
@forkwright
forkwright force-pushed the fix/gate-attestation-rp-branch-waiver branch from 51c8d79 to 92b8f25 Compare July 8, 2026 14:25
@forkwright
forkwright merged commit 5be130b into main Jul 8, 2026
1 check passed
@forkwright
forkwright deleted the fix/gate-attestation-rp-branch-waiver branch July 8, 2026 14:25
forkwright added a commit to forkwright/epitelesis that referenced this pull request Jul 8, 2026
Replace the inline copy (which lacked any release-please waiver, failing every
release PR with 'No Gate-Passed trailer found') with a thin caller of the
canonical reusable, pinned past the branch-shaped release-please waiver
(forkwright/.github#10). One fact, one place.

Gate-Passed: kanon 0.1.6 +stages:fmt,check,clippy,nextest,lint sha:87967f2a249dbd562ab60a83f8e00ac7aa244c42

Co-authored-by: admin <admin@ardentleatherworks.com>
forkwright added a commit to forkwright/koinon that referenced this pull request Jul 8, 2026
Replace the inline copy (which lacked any release-please waiver, failing every
release PR with 'No Gate-Passed trailer found') with a thin caller of the
canonical reusable, pinned past the branch-shaped release-please waiver
(forkwright/.github#10). One fact, one place.

Gate-Passed: kanon 0.1.6 +stages:fmt,check,clippy,nextest,lint sha:e1f5bbf3613d800a989cbb5191a27201b59e0a43

Co-authored-by: admin <admin@ardentleatherworks.com>
forkwright added a commit to forkwright/heurema that referenced this pull request Jul 8, 2026
Replace the inline copy (which lacked any release-please waiver, failing every
release PR with 'No Gate-Passed trailer found') with a thin caller of the
canonical reusable, pinned past the branch-shaped release-please waiver
(forkwright/.github#10). One fact, one place.

Gate-Passed: kanon 0.1.6 +stages:fmt,check,clippy,nextest,lint sha:fe7934d59f1b3d5f22288e7e0b3546f467288ace

Co-authored-by: admin <admin@ardentleatherworks.com>
forkwright added a commit to forkwright/zetesis that referenced this pull request Jul 8, 2026
Replace the inline copy (which lacked any release-please waiver, failing every
release PR with 'No Gate-Passed trailer found') with a thin caller of the
canonical reusable, pinned past the branch-shaped release-please waiver
(forkwright/.github#10). One fact, one place.

Gate-Passed: kanon 0.1.6 +stages:fmt,check,clippy,nextest,lint sha:38df1fa4545de5ddd6d163e331c57a7c1aabaec7

Co-authored-by: admin <admin@ardentleatherworks.com>
forkwright added a commit to forkwright/sphragis that referenced this pull request Jul 8, 2026
Replace the inline copy (which lacked any release-please waiver, failing every
release PR with 'No Gate-Passed trailer found') with a thin caller of the
canonical reusable, pinned past the branch-shaped release-please waiver
(forkwright/.github#10). One fact, one place.

Gate-Passed: kanon 0.1.6 +stages:fmt,check,clippy,nextest,lint sha:f37359ad8909afc24d679265586d080fd00a793d

Co-authored-by: admin <admin@ardentleatherworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant