fix(ci): drop self-cancelling concurrency from security + release-please reusable workflows - #6
Merged
Conversation
…ase reusable workflows security.yml had cancel-in-progress: true with the same group key as callers, causing self-cancellation (0 jobs, failure in 1s). release-please.yml had the same structural issue. Applied the same fix as 66867bc (gate-attestation, codeql, dependabot-auto-merge, no-ai-attribution).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding
security.ymlandrelease-please.ymlreusable workflows had top-levelconcurrency:blocks. When called viauses:, the concurrency group key (github.workflow-github.ref) resolves to the SAME key as the calling workflow's own concurrency group. Withcancel-in-progress: truein security.yml, each new invocation cancels the calling run before any jobs are created — producing the "0 jobs / failure in 1s / workflow file issue" symptom seen on theatron.release-please.ymlhascancel-in-progress: falsebut the same structural issue; removed for consistency and to prevent future breakage ifcancel-in-progressis ever toggled.Fix
Remove the
concurrency:blocks from both reusable workflows. Identical to commit 66867bc which applied the same fix togate-attestation.yml,codeql.yml,dependabot-auto-merge.yml, andno-ai-attribution.yml.Callers that need per-repo concurrency control (theatron, etc.) set their own
concurrency:block — reusable workflows should not override it.