You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PRs #640 (ulid 1.2→3.0) and #641 (rubato 3→4) merged onto main although their own pre-merge Check/Clippy/Test runs failed — both carried genuine compile breaks (fixed forward in #660). Main's push CI has been red or superseded since #639.
Evidence
chore(deps): bump ulid from 1.2.1 to 3.0.0 #640 pre-merge run 29971760416: error[E0599]: no function or associated item named 'new' found for struct 'Ulid' in crates/paroche/src/routes/zone.rs:73 — merged anyway.
At merge time the required set had just been trimmed (hybrid-gate cutover) to gate / gate + cargo audit + cargo deny + osv-scanner + gitleaks + scan; Check/Clippy/Test were no longer required.
For both PRs gate / gate must have reported success despite the tree not compiling — hypothesis: docs_only_exemption (or the trailer route) in the reusable hybrid-gate classified the dependabot diffs (Cargo.toml/Cargo.lock only) as exempt from the full build, so full-gate-build skipped and gate / gate passed vacuously.
Why this matters
A lockfile-only diff is exactly the class MOST in need of a compile check — dependency bumps break trees while touching no source. If the exemption treats manifest/lockfile changes as docs-only, every dependabot PR can merge red.
Desired correction
Verify the hypothesis against the #640/#641gate / gate run logs (route taken, exemption decision). If confirmed: the docs-only classifier in the reusable hybrid-gate (forkwright/.github) must treat Cargo.toml/Cargo.lock (and any build-input file) as code, fleet-wide. Add a regression: a lockfile-only PR must take the full-gate-build route.
Done when: a Cargo.lock-only PR demonstrably runs full-gate-build, and the classifier change is landed in the reusable workflow consumed by all adopted repos.
Finding
PRs #640 (ulid 1.2→3.0) and #641 (rubato 3→4) merged onto main although their own pre-merge
Check/Clippy/Testruns failed — both carried genuine compile breaks (fixed forward in #660). Main's push CI has been red or superseded since #639.Evidence
error[E0599]: no function or associated item named 'new' found for struct 'Ulid'incrates/paroche/src/routes/zone.rs:73— merged anyway.error[E0107](audioadapter 4.0 trait-lifetime removal) incrates/akouo-core/src/output/resample.rs— merged anyway.gate / gate+ cargo audit + cargo deny + osv-scanner + gitleaks + scan;Check/Clippy/Testwere no longer required.gate / gatemust have reported success despite the tree not compiling — hypothesis:docs_only_exemption(or the trailer route) in the reusable hybrid-gate classified the dependabot diffs (Cargo.toml/Cargo.lock only) as exempt from the full build, sofull-gate-buildskipped andgate / gatepassed vacuously.Why this matters
A lockfile-only diff is exactly the class MOST in need of a compile check — dependency bumps break trees while touching no source. If the exemption treats manifest/lockfile changes as docs-only, every dependabot PR can merge red.
Desired correction
Verify the hypothesis against the #640/#641
gate / gaterun logs (route taken, exemption decision). If confirmed: the docs-only classifier in the reusable hybrid-gate (forkwright/.github) must treat Cargo.toml/Cargo.lock (and any build-input file) as code, fleet-wide. Add a regression: a lockfile-only PR must take the full-gate-build route.Done when: a Cargo.lock-only PR demonstrably runs full-gate-build, and the classifier change is landed in the reusable workflow consumed by all adopted repos.