Skip to content

chore: upgrade go-libs for multi-issuers support#125

Merged
sylr merged 1 commit intomainfrom
chore/upgrade-go-libs
Mar 2, 2026
Merged

chore: upgrade go-libs for multi-issuers support#125
sylr merged 1 commit intomainfrom
chore/upgrade-go-libs

Conversation

@sylr
Copy link
Contributor

@sylr sylr commented Mar 2, 2026

Summary by CodeRabbit

  • New Features

    • Added support for multiple authentication issuers, enabling the service to trust additional issuers beyond the base URL configuration.
  • Chores

    • Updated authentication library dependency to the latest version for improved functionality and compatibility.

@sylr sylr marked this pull request as draft March 2, 2026 11:01
@coderabbitai
Copy link

coderabbitai bot commented Mar 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 424eb83 and bec00fe.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • cmd/serve.go
  • go.mod

📝 Walkthrough

Walkthrough

Authentication module refactored from single-issuer to multi-issuer JWT validation. Configuration changed from Issuer string to Issuers list. Provider decorator now returns authlib.Authenticator constructed via authlib.NewJWTAuth, aggregating per-issuer key sets instead of a static key set.

Changes

Cohort / File(s) Summary
Multi-issuer Authentication Support
cmd/serve.go
Updated authlib.ModuleConfig to accept multiple issuers ([]string) and modified fx.Decorate provider to construct per-issuer key sets and return authlib.Authenticator via NewJWTAuth instead of static oidclib.KeySet.
Dependency Update
go.mod
Bumped github.com/formancehq/go-libs/v3 from v3.4.0 to v3.6.1.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 One issuer became two, then three, then more,
A rabbit's delight—no single door!
Per-issuer key sets now dance in a map,
NewJWTAuth grins, closing the gap. ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the primary change: upgrading go-libs dependency to enable multi-issuers support in the authentication module.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/upgrade-go-libs

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sylr sylr force-pushed the chore/upgrade-go-libs branch from 5fada69 to bc466a3 Compare March 2, 2026 12:19
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@sylr sylr force-pushed the chore/upgrade-go-libs branch from bc466a3 to bec00fe Compare March 2, 2026 13:22
@sylr sylr marked this pull request as ready for review March 2, 2026 14:09
@sylr sylr merged commit 327f695 into main Mar 2, 2026
6 checks passed
@sylr sylr deleted the chore/upgrade-go-libs branch March 2, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants