chore: remove all earthly-related files and references#399
Open
chore: remove all earthly-related files and references#399
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
⛔ Files ignored due to path filters (10)
📒 Files selected for processing (5)
💤 Files with no reviewable changes (3)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughRemoved Earthly build files and Changes
Sequence Diagram(s)mermaid Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
Justfile (1)
75-85: Consider addingpipefailfor robust error handling.The version extraction pipeline on line 80 could silently produce an empty string if
grepfails (e.g., malformed Chart.yaml), since only the last command's exit status is checked withoutpipefail. This would result in an invalid version like-<suffix>.♻️ Suggested improvement
helm-package suffix='': helm-update #!/bin/bash - set -e + set -eo pipefail for dir in $(ls -d helm/*); do if [ -n "{{suffix}}" ]; then version=$(grep '^version:' "$dir/Chart.yaml" | awk '{print $2}' | tr -d '"')🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Justfile` around lines 75 - 85, In the helm-package recipe in the Justfile, enable robust shell error handling by adding pipefail (e.g., change the shebang block to use set -euo pipefail) so the grep|awk|tr pipeline in the version extraction will fail the script if any stage fails; additionally, after computing the version variable in the branch that uses suffix, validate that version is non-empty and exit with an error (or log and abort) before calling helm package to avoid producing an invalid "-{{suffix}}" package; key identifiers: the helm-package Justfile recipe, the version variable computed from grep/awk/tr, and the helm package invocation.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@Justfile`:
- Around line 75-85: In the helm-package recipe in the Justfile, enable robust
shell error handling by adding pipefail (e.g., change the shebang block to use
set -euo pipefail) so the grep|awk|tr pipeline in the version extraction will
fail the script if any stage fails; additionally, after computing the version
variable in the branch that uses suffix, validate that version is non-empty and
exit with an error (or log and abort) before calling helm package to avoid
producing an invalid "-{{suffix}}" package; key identifiers: the helm-package
Justfile recipe, the version variable computed from grep/awk/tr, and the helm
package invocation.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (10)
.earthly/configuration/Chart.yamlis excluded by!**/*.yaml.earthly/configuration/templates/elasticsearch-secret.yamlis excluded by!**/*.yaml.earthly/configuration/templates/postgres-secret.yamlis excluded by!**/*.yaml.earthly/configuration/templates/settings.yamlis excluded by!**/*.yaml.earthly/configuration/templates/temporal-secret.yamlis excluded by!**/*.yaml.earthly/configuration/values.yamlis excluded by!**/*.yaml.earthly/k8s-versions.yamlis excluded by!**/*.yaml.github/actions/env/action.ymlis excluded by!**/*.yml.github/workflows/main.ymlis excluded by!**/*.yml.goreleaser.ymlis excluded by!**/*.yml
📒 Files selected for processing (5)
.earthly/configuration/.helmignoreEarthfileJustfileflake.nixtools/utils/Earthfile
💤 Files with no reviewable changes (4)
- .earthly/configuration/.helmignore
- flake.nix
- Earthfile
- tools/utils/Earthfile
Dav-14
force-pushed
the
chore/remove-earthly
branch
from
1eaee01 to
c47041b
Compare
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
Justfile (1)
75-87: Use dot-separated prerelease identifiers when suffixing chart versions.When appending a suffix to a pre-release version, use a dot (
.) separator instead of a hyphen to align with SemVer best practices. For example,1.2.3-rc.1.{{suffix}}is preferred over1.2.3-rc.1-{{suffix}}because dot-separated identifiers preserve numeric ordering in version constraints (e.g.,rc.1sorts beforerc.2).🔧 Suggested adjustment
for dir in $(ls -d helm/*); do if [ -n "{{suffix}}" ]; then version=$(grep '^version:' "$dir/Chart.yaml" | awk '{print $2}' | tr -d '"') - pushd "$dir" && helm package . --version "${version}-{{suffix}}" && popd + if [[ "$version" == *-* ]]; then + pkg_version="${version}.{{suffix}}" + else + pkg_version="${version}-{{suffix}}" + fi + pushd "$dir" && helm package . --version "$pkg_version" && popd else pushd "$dir" && helm package . && popd fi done🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Justfile` around lines 75 - 87, The helm-package recipe currently appends the suffix with a hyphen regardless of whether the Chart.yaml version is a pre-release; modify the suffix logic in helm-package (the shell block using variable version from Chart.yaml) to detect pre-release versions (presence of '-') and, if present, append the suffix with a dot (e.g., "${version}.{{suffix}}"), otherwise keep the existing hyphen form ("${version}-{{suffix}}"); update the packaging command in helm-package to use the chosen version string when calling helm package.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@Justfile`:
- Around line 75-87: The helm-package recipe currently appends the suffix with a
hyphen regardless of whether the Chart.yaml version is a pre-release; modify the
suffix logic in helm-package (the shell block using variable version from
Chart.yaml) to detect pre-release versions (presence of '-') and, if present,
append the suffix with a dot (e.g., "${version}.{{suffix}}"), otherwise keep the
existing hyphen form ("${version}-{{suffix}}"); update the packaging command in
helm-package to use the chosen version string when calling helm package.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
.github/workflows/main.ymlis excluded by!**/*.yml
📒 Files selected for processing (2)
Justfileflake.nix
🚧 Files skipped from review as they are similar to previous changes (1)
- flake.nix
Dav-14
force-pushed
the
chore/remove-earthly
branch
6 times, most recently
from
3dfaf90 to
02972bf
Compare
- Delete Earthfiles and .earthly/ directory - Remove earthly setup from CI action - Replace earthly deploy with argocd CLI via Just target - Replace earthly with argocd in flake.nix Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Dav-14
force-pushed
the
chore/remove-earthly
branch
from
02972bf to
afbfb1d
Compare
gfyrag
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Earthfile(root) andtools/utils/Earthfile.earthly/directory (helm configuration used by earthly deploy targets)earthly/actions-setupand git branch workaround from.github/actions/env/action.ymlearthlyfromflake.nixdev dependenciesargocdCLI approach (matching membership-api pattern):deploy-stagingJust target callingargocddirectlyDeployCI job with Tailscale VPN connectivityargocdtoflake.nixdev dependenciesTest plan
🤖 Generated with Claude Code