feat(licence): opt-in licence management via --licence-secret flag#410
feat(licence): opt-in licence management via --licence-secret flag#410
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
⛔ Files ignored due to path filters (5)
📒 Files selected for processing (8)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (4)
WalkthroughMultiple API resource types were marked as Enterprise Edition by changing their Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
… EE and use conditional payments image - Set IsEE() to return true for Auth, Orchestration, Search, Wallets, and Webhooks modules - Add formance.com/is-ee=true kubebuilder label to Auth CRD - Use payments-ee Docker image when a licence is present and version >= v3.2.0-beta.0
…configured Reject deployment of modules marked as EE (Auth, Orchestration, Search, Wallets, Webhooks, Reconciliation) when no licence secret is provided, setting them to Ready=false with a clear error message. Also simplify licence env vars by removing unused cluster ID lookup.
Remove LICENCE_ENABLED env var since modules can detect licence from the presence of LICENCE_TOKEN. Remove EE module blocking check as licence is now opt-in. Add startup log indicating whether licence management is enabled or disabled.
11c444b to
7c867d7
Compare
Summary
IsEE() = true--licence-secretis passed, licence env vars (LICENCE_TOKEN,LICENCE_ISSUER,LICENCE_VALIDATE_TICK) are injected into EE module pods; when not passed (default), no licence enforcementLICENCE_ENABLEDenv var: modules detect licence activation from the presence ofLICENCE_TOKENinsteadLICENCE_CLUSTER_ID: no longer needed (kube-system namespace lookup removed)payments-eeimage when licence secret is configured and version >= v3.2.0-beta.0, falls back topayments(CE) otherwiseTest plan
--licence-secret→ all modules deploy normally, no licence env vars injected, log shows "licence management disabled"--licence-secret=<secret>→ EE modules getLICENCE_TOKEN/LICENCE_ISSUERenv vars, log shows "licence management enabled"paymentsimage without licence,payments-eewith licence (version >= v3.2.0-beta.0)