Skip to content

FIO-9751 updated modal edit window for components with hidden tabs #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnformio merged 1 commit into from
Feb 24, 2025
Merged

FIO-9751 updated modal edit window for components with hidden tabs #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions src/templates/bootstrap4/builderComponent/form.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,17 @@
>
<i class="{{ctx.iconClass('save')}}"></i>
</div>
<div
role="button"
aria-label="Edit json button. Click to edit json of the current component"
tabindex="-1"
class="btn btn-xxs btn-default component-settings-button component-settings-button-edit-json"
ref="editJson"
>
<i class="{{ctx.iconClass('wrench')}}"></i>
</div>
{% if (ctx.editJson !== false) { %}
<div
role="button"
aria-label="Edit json button. Click to edit json of the current component"
tabindex="-1"
class="btn btn-xxs btn-default component-settings-button component-settings-button-edit-json"
ref="editJson"
>
<i class="{{ctx.iconClass('wrench')}}"></i>
</div>
{% } %}
{% } %}
<div
role="button"
Expand All @@ -48,7 +50,7 @@
>
<i class="{{ctx.iconClass('move')}}"></i>
</div>
{% if (!(ctx.design && ctx.childComponent.type === 'reviewpage')) { %}
{% if (!(ctx.design && ctx.childComponent.type === 'reviewpage') && ctx.editComponent) { %}
<div
role="button"
aria-label="Edit button. Click to open component settings modal window"
Expand Down
22 changes: 12 additions & 10 deletions src/templates/bootstrap5/builderComponent/form.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,17 @@
>
<i class="{{ctx.iconClass('save')}}"></i>
</div>
<div
role="button"
aria-label="Edit json button. Click to edit json of the current component"
tabindex="-1"
class="btn btn-xxs btn-default component-settings-button component-settings-button-edit-json"
ref="editJson"
>
<i class="{{ctx.iconClass('wrench')}}"></i>
</div>
{% if (ctx.editJson !== false) { %}
<div
role="button"
aria-label="Edit json button. Click to edit json of the current component"
tabindex="-1"
class="btn btn-xxs btn-default component-settings-button component-settings-button-edit-json"
ref="editJson"
>
<i class="{{ctx.iconClass('wrench')}}"></i>
</div>
{% } %}
{% } %}
<div
role="button"
Expand All @@ -48,7 +50,7 @@
>
<i class="{{ctx.iconClass('move')}}"></i>
</div>
{% if (!(ctx.design && ctx.childComponent.type === 'reviewpage')) { %}
{% if (!(ctx.design && ctx.childComponent.type === 'reviewpage') && ctx.editComponent) { %}
<div
role="button"
aria-label="Edit button. Click to open component settings modal window"
Expand Down