Conversation
Signed-off-by: Davis Wertheimer <davis.wertheimer@ibm.com>
Signed-off-by: Davis Wertheimer <davis.wertheimer@ibm.com>
Signed-off-by: Davis Wertheimer <davis.wertheimer@ibm.com>
Signed-off-by: Davis Wertheimer <davis.wertheimer@ibm.com>
Signed-off-by: Davis Wertheimer <davis.wertheimer@ibm.com>
Signed-off-by: Davis Wertheimer <davis.wertheimer@ibm.com>
Signed-off-by: Davis Wertheimer <davis.wertheimer@ibm.com>
lchu6
approved these changes
May 23, 2025
Contributor
lchu6
left a comment
There was a problem hiding this comment.
LG.
only comment is this PR is a little fat given both dataloader fix and FIM. separating the two might be better. Not a big deal though, approving the changes.
Signed-off-by: Davis Wertheimer <davis.wertheimer@ibm.com>
Signed-off-by: Davis Wertheimer <davis.wertheimer@ibm.com>
Signed-off-by: Davis Wertheimer <davis.wertheimer@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A collection of dataloader updates and fixes mirrored from the torchtitan repo. Changes include:
FIXES FOR HANGS AND FREEZES:
FIXES FOR CRASHES:
FIXES CONVERGENCE BEHAVIOR:
QUALITY OF LIFE: