site: adopt weft design system + fix Pages (Actions) config#65
Conversation
Design-system consistency pass (audit-driven): - .eyebrow re-implementation -> shared .weft-eyebrow atom (canonical 11px/medium overline; corrects a 12px/regular drift). - token hygiene: 64px->var(--space-10), 3px->var(--radius-sm), raw rgba(0,0,0,.08) inset -> var(--border-hairline). The D4 display-font fix (Space Grotesk retired -> IBM Plex Sans) lands via the shared @weft/site-kit on the next vendor refresh. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The deploy job used deploy-pages@v4 with no configure-pages step, so it did not self-heal the repo's Pages source — which was still 'Deploy from a branch' (legacy: gh-pages / rc5-docs), causing the Actions deploy to fail or be ignored. Add actions/configure-pages@v5 (enablement: true) to the build job so the source is pinned to build_type=workflow on every run. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2d0540dd82
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| uses: actions/configure-pages@v5 | ||
| with: | ||
| enablement: true |
There was a problem hiding this comment.
In the scenario called out here—Pages already exists but is still configured as “Deploy from a branch”—actions/configure-pages@v5 does not switch the site to build_type=workflow; its v5 code returns the existing Pages site after getPages succeeds and only calls createPagesSite({ build_type: 'workflow' }) when no site exists. I checked actions/configure-pages@v5's action code for this behavior, so this step will leave the repo in branch mode and the later actions/deploy-pages deployment still won't publish from the uploaded artifact.
Useful? React with 👍 / 👎.
1 participant
Design-system consistency pass + Pages config fix (see commits). Site/CI only; no src changes.
🤖 Generated with Claude Code