test(ci): align live-Loomweave release meta-test with skip-not-fail#19
Merged
Merged
Conversation
PR #18 restored skip-not-fail for the live-loomweave-conformance job (owner decision 2026-06-25: no live Loomweave conformance in remote CI), but test_release_publish_requires_live_loomweave_conformance still asserted the fail-closed contract ("Missing required release conformance environment"), so the release build's test gate went red. Update the meta-test to the skip-not-fail contract: publish is still chained through the conformance job; the job no-ops with a notice when the oracle config is absent (configured=false, "not blocking publish") and is not fail-closed; the oracle still runs for real when configured (gated on steps.oracle_config.outputs.configured == 'true'); and the HMAC secret stays scoped to only the detect + oracle steps. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #18. That PR restored the skip-not-fail behavior for the
live-loomweave-conformancejob (owner decision 2026-06-25: Legis does not run live Loomweave conformance in remote CI), buttests/test_ci_workflow.py::test_release_publish_requires_live_loomweave_conformancestill asserted the fail-closed contract ("Missing required release conformance environment"). That mismatch turned the release build's test gate red and blocked the v1.2.0 publish.This updates the meta-test to the skip-not-fail contract, keeping the meaningful invariants:
publishis still chained throughlive-loomweave-conformance(needs).::notice::(configured=false, "not blocking publish") instead of erroring.steps.oracle_config.outputs.configured == 'true'.LEGIS_LOOMWEAVE_HMAC_KEYsecret stays scoped to only the detect + oracle steps (never job-level env).🤖 Generated with Claude Code