Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix arbitrary code execution via git config in untrusted repositories#52

Open
tachyon-beep wants to merge 1 commit into
mainfrom
sentinel-rce-git-config-4268978496008176289
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix arbitrary code execution via git config in untrusted repositories#52
tachyon-beep wants to merge 1 commit into
mainfrom
sentinel-rce-git-config-4268978496008176289

Conversation

@tachyon-beep

Copy link
Copy Markdown
Collaborator

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: Python's subprocess.run(["git", ...]) is vulnerable to RCE if an attacker provides a malicious .git/config configuring core.fsmonitor to execute arbitrary shell scripts. Although src/wardline/core/attest.py properly safeguarded this with _SAFE_GIT_CONFIG, other files (delta.py, legis.py) were vulnerable to this when running git against an untrusted repository.
🎯 Impact: Arbitrary code execution when the static analyzer runs on a maliciously crafted untrusted repository.
πŸ”§ Fix: Updated all subprocess.run calls that invoke git across delta.py and legis.py to use _SAFE_GIT_CONFIG = ("-c", "core.fsmonitor=false"), consistent with attest.py.
βœ… Verification: Ensure the updated test_delta.py passes successfully, validating that the parameter is properly passed. Also validated via make ci. Included a Sentinel journal entry as required.


PR created automatically by Jules for task 4268978496008176289 started by @tachyon-beep

…n untrusted repositories

Co-authored-by: tachyon-beep <544926+tachyon-beep@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant