π‘οΈ Sentinel: [CRITICAL] Fix arbitrary code execution via git config in untrusted repositories#52
Conversation
β¦n untrusted repositories Co-authored-by: tachyon-beep <544926+tachyon-beep@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: Python's
subprocess.run(["git", ...])is vulnerable to RCE if an attacker provides a malicious.git/configconfiguringcore.fsmonitorto execute arbitrary shell scripts. Althoughsrc/wardline/core/attest.pyproperly safeguarded this with_SAFE_GIT_CONFIG, other files (delta.py,legis.py) were vulnerable to this when running git against an untrusted repository.π― Impact: Arbitrary code execution when the static analyzer runs on a maliciously crafted untrusted repository.
π§ Fix: Updated all
subprocess.runcalls that invoke git acrossdelta.pyandlegis.pyto use_SAFE_GIT_CONFIG = ("-c", "core.fsmonitor=false"), consistent withattest.py.β Verification: Ensure the updated
test_delta.pypasses successfully, validating that the parameter is properly passed. Also validated viamake ci. Included a Sentinel journal entry as required.PR created automatically by Jules for task 4268978496008176289 started by @tachyon-beep