π‘οΈ Sentinel: [CRITICAL] Fix command injection via git config#59
π‘οΈ Sentinel: [CRITICAL] Fix command injection via git config#59tachyon-beep wants to merge 2 commits into
Conversation
Co-authored-by: tachyon-beep <544926+tachyon-beep@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Co-authored-by: tachyon-beep <544926+tachyon-beep@users.noreply.github.com>
π¨ Severity: CRITICAL
π‘ Vulnerability: Potential command injection via malicious
.git/configconfigurations when executinggitcommands on untrusted repositories viasubprocess.run.π― Impact: A malicious repository could achieve local code execution by configuring a malicious
core.fsmonitorscript that runs automatically on certaingitcommands.π§ Fix: Add
_SAFE_GIT_CONFIG = ("-c", "core.fsmonitor=false")to allgitinvocations withinsrc/wardline/core/delta.pyandsrc/wardline/core/legis.py.β Verification: Ensure the test suite passes, particularly tests verifying the mocked arguments to
subprocess.run.PR created automatically by Jules for task 18445620665194592914 started by @tachyon-beep