🛡️ Sentinel: [CRITICAL/HIGH] Fix git fsmonitor RCE vulnerability#62
🛡️ Sentinel: [CRITICAL/HIGH] Fix git fsmonitor RCE vulnerability#62tachyon-beep wants to merge 1 commit into
Conversation
Added `_SAFE_GIT_CONFIG = ("-c", "core.fsmonitor=false")` to `src/wardline/core/delta.py` and `src/wardline/core/legis.py` and updated all `subprocess.run(["git", ...])` calls to use it. This prevents arbitrary local code execution when running git commands against untrusted repositories containing malicious `.git/config` files that exploit the `core.fsmonitor` setting. Updated the mock arguments in `tests/unit/core/test_delta.py` to match the new invocation.
Co-authored-by: tachyon-beep <544926+tachyon-beep@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: HIGH
💡 Vulnerability: When
subprocess.runinvokesgitoperations (likegit diff,git ls-files,git rev-parse) inside untrusted repositories, Git can be instructed to run arbitrary code if the repository contains a malicious.git/configfile that sets thecore.fsmonitorconfiguration to an executable script.🎯 Impact: Attackers could gain Remote Code Execution (RCE) on the system running Wardline by tricking a user into scanning a repository that includes a malicious
.gitdirectory.🔧 Fix: Propagated the
_SAFE_GIT_CONFIG = ("-c", "core.fsmonitor=false")mitigation (already present inattest.py) todelta.pyandlegis.py. This prepends the configuration override to allgitsubprocess commands, explicitly disabling the filesystem monitor daemon regardless of the local repo configuration.✅ Verification: Ran unit tests (
make test), ensuring thetest_delta.pyassertions reflect the updated command line arguments. All tests, static typing (make typecheck) and formatting (make lint) pass successfully.PR created automatically by Jules for task 10424184650315055871 started by @tachyon-beep