π‘οΈ Sentinel: [CRITICAL] Fix git config arbitrary code execution vulnerability#65
π‘οΈ Sentinel: [CRITICAL] Fix git config arbitrary code execution vulnerability#65tachyon-beep wants to merge 1 commit into
Conversation
β¦rability Added `-c core.fsmonitor=false` to git subprocess calls in `delta.py` and `legis.py` to prevent arbitrary code execution from malicious `.git/config` files in untrusted repositories. Co-authored-by: tachyon-beep <544926+tachyon-beep@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
gitviasubprocessagainst potentially untrusted directories can lead to local code execution via malicious.git/configfiles (e.g.core.fsmonitor).-c core.fsmonitor=false(_SAFE_GIT_CONFIG) to allgitsubprocess calls insrc/wardline/core/delta.pyandsrc/wardline/core/legis.py. Updatedtests/unit/core/test_delta.pyto match the new command line arguments. Added an entry to.jules/sentinel.mddocumenting this learning.make test,make format,make lint).PR created automatically by Jules for task 5847839527563382106 started by @tachyon-beep