Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix local code execution via malicious git config#67

Open
tachyon-beep wants to merge 1 commit into
mainfrom
sentinel/git-fsmonitor-rce-14872374062354284865
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix local code execution via malicious git config#67
tachyon-beep wants to merge 1 commit into
mainfrom
sentinel/git-fsmonitor-rce-14872374062354284865

Conversation

@tachyon-beep

Copy link
Copy Markdown
Collaborator

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: Running git commands (like rev-parse, diff, ls-files) via subprocess.run inside an untrusted directory can lead to arbitrary code execution if the directory contains a malicious .git/config configuring core.fsmonitor to run a malicious executable.
🎯 Impact: A malicious actor could execute arbitrary code when the scanner examines an untrusted repository.
πŸ”§ Fix: Explicitly passed ("-c", "core.fsmonitor=false") as _SAFE_GIT_CONFIG to all git invocations via subprocess.run in src/wardline/core/delta.py and src/wardline/core/legis.py.
βœ… Verification: Ran make test, make lint, make format, and make typecheck successfully, and ensured that no subprocess.run(["git", ...]) are missing the _SAFE_GIT_CONFIG.


PR created automatically by Jules for task 14872374062354284865 started by @tachyon-beep

…nfig

Co-authored-by: tachyon-beep <544926+tachyon-beep@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant