π‘οΈ Sentinel: [CRITICAL] Fix local code execution via malicious git config#67
π‘οΈ Sentinel: [CRITICAL] Fix local code execution via malicious git config#67tachyon-beep wants to merge 1 commit into
Conversation
β¦nfig Co-authored-by: tachyon-beep <544926+tachyon-beep@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: Running
gitcommands (likerev-parse,diff,ls-files) viasubprocess.runinside an untrusted directory can lead to arbitrary code execution if the directory contains a malicious.git/configconfiguringcore.fsmonitorto run a malicious executable.π― Impact: A malicious actor could execute arbitrary code when the scanner examines an untrusted repository.
π§ Fix: Explicitly passed
("-c", "core.fsmonitor=false")as_SAFE_GIT_CONFIGto allgitinvocations viasubprocess.runinsrc/wardline/core/delta.pyandsrc/wardline/core/legis.py.β Verification: Ran
make test,make lint,make format, andmake typechecksuccessfully, and ensured that nosubprocess.run(["git", ...])are missing the_SAFE_GIT_CONFIG.PR created automatically by Jules for task 14872374062354284865 started by @tachyon-beep