π‘οΈ Sentinel: [CRITICAL] Fix arbitrary code execution via git config#68
π‘οΈ Sentinel: [CRITICAL] Fix arbitrary code execution via git config#68tachyon-beep wants to merge 1 commit into
Conversation
Co-authored-by: tachyon-beep <544926+tachyon-beep@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: Calling
gitviasubprocessagainst potentially untrusted directories can lead to local code execution via malicious.git/configfiles (e.g.,core.fsmonitorexploitation). Somegitcommands indelta.pyandlegis.pylacked the_SAFE_GIT_CONFIGparameter.π― Impact: Attackers could gain local code execution if they can control the
rootdirectory provided towardlinewhen using these features.π§ Fix: Add the
_SAFE_GIT_CONFIGparameter to all remaininggitsubprocess calls insrc/wardline/core/delta.pyandsrc/wardline/core/legis.pyto prevent loading malicious config files.β Verification: Ran
make testandmake lintto ensure test assertions pass with updated parameters and functionality has not regressed.PR created automatically by Jules for task 10268765486506753183 started by @tachyon-beep