BugFix/small fixes

[loaflover]

just some minor fixes, with varying importance.

openssh plugin:
removed unused variable.
improved find_sshd_directory function, removing a redundent check and allowing it to return None.

opensshd plugin:
updated to work with new find_sshd_directory function.

iis plugin:
moved variable assignment inside the If block it is used in. very slightly better for performance.

clsid plugin:
changed key paths from dict to standalone consts.
fixed create_records function docstring
fixed plugin functions and create_records function to support the new CONST types.

firewall plugin:
added missing commas to a list.

ual plugin:
changed the way the log and db dir were stored.

test_opensshd:
made work with the new find_sshd_directory function

[loaflover]

hey (:

i fixed a few small things that where bothering me.
fixes range from slightly important to minuscule

specifically for clsid, im honestly not sure if there was a reason it was how it was before, but i think what i did looks nicer.

[Schamper]

Do any of these changes fix bugs you were running into, or are these just code style changes? If the former, would you mind adding unit tests for those scenarios?

[codspeed-hq]

Merging this PR will not alter performance

✅ 12 untouched benchmarks

---

_{Comparing loaflover:feature/small-fixes (e6e0060) with main (b07019c)}

[loaflover]

i havent really seen these when running, and honestly most of these arent really bugs (i may have to change the name 😅)

only one is a real bug and i dont really know how i could test for it, as it was just a list with missing commas. the rest are readability/efficiency upgrades.

[Schamper]

Alright, no problem. Can you fix the failing tests before I look further?

[loaflover]

i fixed all failed tests, i tried to do it in the least invasive way.

hope its good (:

[Schamper]

Can you specify in the PR description what everything is that you fixed/changed? Useful for creating a changelog later.

[codecov]

Codecov Report

❌ Patch coverage is 88.57143% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.12%. Comparing base (b07019c) to head (e6e0060).
⚠️ Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
dissect/target/plugins/os/windows/regf/clsid.py	80.95%	4 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1592   +/-   ##
=======================================
  Coverage   81.12%   81.12%           
=======================================
  Files         401      401           
  Lines       35091    35093    +2     
=======================================
+ Hits        28467    28469    +2     
  Misses       6624     6624           

Flag	Coverage Δ
unittests	81.12% <88.57%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[loaflover]

Can you specify in the PR description what everything is that you fixed/changed? Useful for creating a changelog later.

sorry for the delay 😅
sure thing, on it.

edit:
done (: