-
Notifications
You must be signed in to change notification settings - Fork 91
Add file descriptor and fdinfo parsing to Linux #1609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Torres773
wants to merge
4
commits into
fox-it:main
Choose a base branch
from
Torres773:proc-fd
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
9008bd0
Added file descriptors iterator to ProcProcess
Torres773 399be09
Merge branch 'main' into proc-fd
Torres773 8920bc8
Refactor FileDescriptor to use cached properties and fix linting
Torres773 fafa0cb
Update dissect/target/plugins/os/unix/linux/proc.py
Torres773 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,6 +30,11 @@ def test_process(target_linux_users: Target, fs_linux_proc: VirtualFilesystem) - | |
| assert environ[0].variable == "VAR" | ||
| assert environ[0].contents == "1" | ||
|
|
||
| fd = list(process.fd()) | ||
| assert "socket" in fd[0].link.name | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This not fails due to |
||
| assert fd[0].info["pos"] == "0" | ||
| assert fd[0].info["flags"] == "00000002" | ||
|
|
||
|
|
||
| def test_process_not_found(target_linux_users: Target, fs_linux_proc: VirtualFilesystem) -> None: | ||
| target_linux_users.add_plugin(ProcPlugin) | ||
|
|
@@ -52,6 +57,11 @@ def test_processes(target_linux_users: Target, fs_linux_proc: VirtualFilesystem) | |
| assert env.variable == "VAR" | ||
| assert env.contents == "1" | ||
|
|
||
| for fd in process.fd(): | ||
| assert "socket" in fd.link.name | ||
| assert fd.info["pos"] == "0" | ||
| assert fd.info["flags"] == "00000002" | ||
|
|
||
|
|
||
| def test_processes_without_boottime(target_linux_users: Target, fs_linux_proc: VirtualFilesystem) -> None: | ||
| target_linux_users.add_plugin(ProcPlugin) | ||
|
|
@@ -70,6 +80,11 @@ def test_processes_without_boottime(target_linux_users: Target, fs_linux_proc: V | |
| assert env.variable == "VAR" | ||
| assert env.contents == "1" | ||
|
|
||
| for fd in process.fd(): | ||
| assert "socket" in fd.link.name | ||
| assert fd.info["pos"] == "0" | ||
| assert fd.info["flags"] == "00000002" | ||
|
|
||
|
|
||
| def test_proc_plugin_incompatible(target_linux_users: Target, fs_linux: VirtualFilesystem) -> None: | ||
| with pytest.raises(UnsupportedPluginError, match="No /proc directory found"): | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
unknowna value used in/proc/[pid]/fdsymlink targets? If not, better to keep it as close toprocfsas possible. Your test case also fails now because you cast this to a string.Additionaly, can you implement a test case for when the
Exceptionoccurs?