Improve parsing of plugin arguments in target-query#1619
Open
Improve parsing of plugin arguments in target-query#1619
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1619 +/- ##
==========================================
+ Coverage 81.09% 81.12% +0.02%
==========================================
Files 402 402
Lines 35264 35274 +10
==========================================
+ Hits 28599 28616 +17
+ Misses 6665 6658 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yunzheng
force-pushed
the
bugfix/target-query-argparse-handling
branch
from
750b9ea to
3c8b561
Compare
Contributor
|
Perhaps this makes implementing #1493 easier. |
JSCU-CNI
reviewed
Mar 13, 2026
Member
Author
|
Windows tests are failing due to windows_path vs posix_path. will look into it later. update: changed the test to match on inode instead |
yunzheng
force-pushed
the
bugfix/target-query-argparse-handling
branch
from
788599e to
9b53c3c
Compare
yunzheng
force-pushed
the
bugfix/target-query-argparse-handling
branch
from
9b53c3c to
f8505bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the suggested solution described in #1508, the described edgecase is left open.
It mainly gets the supported argparse arguments from the requested plugins to
target-query, and then reparses the arguments again so it properly parses known plugin flags. This essentially fixes the problem described in the issue.Unknown arguments/flags now also throw an error, which before would go unnoticed.
resolves #1508, #1362