Add McAfee Endpoint Security ATP JSON parser#1640
Draft
EarthGrob wants to merge 5 commits intofox-it:mainfrom
Draft
Add McAfee Endpoint Security ATP JSON parser#1640EarthGrob wants to merge 5 commits intofox-it:mainfrom
EarthGrob wants to merge 5 commits intofox-it:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add McAfee Endpoint Security ATP JSON parser
Extending the
mcafeeplugin with a function that parses the JSON files at pathsysvol/ProgramData/McAfee/Endpoint Security/ATP.Changes
sysvol/ProgramData/McAfee/Endpoint Security/ATP.McAfeeAtpRemediationRecordto structure the parsed data and preserve the raw JSON for forensic context.atp()export to theMcAfeePlugin._iter_remediation_entries()to ensure only entries with actual threat identifiers (e.g.,AlertID,ThreatName) are yielded, discarding generic software statuses._parse_atp_timestamp()) to safely handle epoch time in seconds, milliseconds, and microseconds.test_mcafee.pycovering successful extraction, noise filtering, timestamp boundaries, and graceful handling of malformed JSON.How to test:
Run the included unit tests via:
pytest tests/plugins/apps/av/test_mcafee.py -vIssue