Skip to content

test: prune redundant cases and reduce fixture cost - #231

Merged
fraa2a merged 12 commits into
mainfrom
refactor/test-suite
Oct 23, 2026
Merged

fraa2a merged 12 commits into
mainfrom
refactor/test-suite

Conversation

@fraa2a

@fraa2a fraa2a commented Oct 21, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Remove duplicate Node probes while retaining actual GoFile and FlexSearch Rust-runtime coverage.
  • Consolidate covered Rust cases and strengthen assertions for cache contents, migrations, recovery, privacy, IPC, filesystem safety, logging and scheduling.
  • Replace desktop cleanup and startup scheduling tests of test-only helpers with real production-path tests; remove the two unused cfg(test) helpers.
  • Correct Steam account target assertions, PICS icon selection, Windows path fixtures and names that overstated the tested contract.
  • Keep subprocess, archive safety, symlink, crash recovery and opt-in live/native tests. Use smaller or sparse fixtures where appropriate.
  • Remove three repeated Windows test executions already included in their module suite. Run full Steam library-discovery and import modules on Windows so portable-path fixtures are actually executed, not merely compiled.

Review scope

  • Individually reviewed all 576 tests in the original source inventory against implementation, helpers, assertions and overlapping coverage.
  • The inventory was recorded after the first six Rust consolidations and includes platform-specific cases, so it differs from Linux collection.
  • Fifteen Rust cases removed or consolidated across the complete PR. Current source inventory: 567 tests.
  • No audit Markdown, dependencies, frontend application changes or production application changes. Production prefixes verified unchanged in all 46 modified Rust files, excluding the two removed cfg(test) helpers.
  • Stacked on build: streamline CI and add AUR development package #230; unrelated changes in the original checkout are excluded. Neither PR is merged.
  • This is a source review, not a claim of exhaustive behavioral coverage or a controlled performance benchmark.

Validation

  • Current commit a29be9f passes CI run 39683882178: documentation, frontend, Rust, native Linux and native Windows checks. Release is intentionally skipped.
  • Linux Rust: 560 passed, zero failed, four ignored (564 collected). Formatting and Clippy pass.
  • Expanded Windows Steam discovery/import tests pass, including portable paths, VDF escaping and deterministic appinfo cache invalidation fixtures.
  • All 157 Node tests and 11 Python tests pass locally. Workflow actionlint and git diff checks pass.
  • Earlier Windows execution exposed a timestamp-dependent fixture; it was corrected without production changes. No failed run is counted as passing validation.

Base automatically changed from chore/ci-aur-development to main October 22, 2026 13:25
@fraa2a
fraa2a changed the base branch from chore/ci-aur-development to main October 22, 2026 13:25
@fraa2a
fraa2a merged commit 3871c5d into main Oct 23, 2026
7 checks passed
@fraa2a
fraa2a deleted the refactor/test-suite branch October 23, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant