Remove legacy HASHPOOL#27
Open
kkovalenko-web wants to merge 1 commit into
Open
Conversation
kkovalenko-web
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the inherited
HASHPOOLpool entry (id 64) frompools-v2.json.HashPoolPro blocks on Fractal Bitcoin are currently misidentified as
HASHPOOLinstead ofHashPoolPro(id 1017). This causes the wrong pool name and logo to appear on mempool.fractalbitcoin.io.Problem
The legacy
HASHPOOLentry (id 64) was copied from the upstream mempool/mining-pools catalog. It was originally added to identify historical Bitcoin blocks mined by hashpool.com using the coinbase tagHASHPOOL.HashPoolPro (id 1017) was added separately and uses
/hashpoolpro.com/in its coinbase scriptSig.Mempool matches mining pools by iterating entries in id order and applying address and regex tag matching (case-insensitive). The regex tag
HASHPOOLmatches as a substring inside/hashpoolpro.com/, so HashPoolPro blocks are incorrectly attributed to id 64 before id 1017 is evaluated.Example: block 1928526 contains:
/hashpoolpro.com/bc1qsskm85t36pd0c7v3cdva0uhwuv5wwuz6nl93xf(listed under HashPoolPro)Yet it is displayed as
HASHPOOL(slughashpool) instead ofHashPoolPro(slughashpoolpro).Why remove instead of modifying the tag?
On Fractal Bitcoin, all blocks currently attributed to
HASHPOOLcontain the HashPoolPro coinbase tag/hashpoolpro.com/. There is no evidence that hashpool.com operates on Fractal Bitcoin with its own coinbase tag.Since this entry only causes false positives and has no Fractal-specific mining activity, removing it is the cleanest fix. HashPoolPro (id 1017) will be correctly matched by its payout addresses and
/hashpoolpro.com/tag.Expected result
After merge and block re-indexing:
hashpoolpro.svgfrom mining-pool-logos will be used