Add CI for submitting plugins to Marketplace on merge #548

niekert · 2026-02-05T13:01:46Z

Description

This PR adds new Github action workflows:

Submit on Merge

Runs when a PR is merged and the Submit on merge label is added to a PR
Extracts the Changelog from the PR body
Submits a new version of a Plugin for each plugin that has changed files

Submit Plugin

Manually callable with a pluginPath and changelog input
Submits a new version of the given plugin to the marketplace
Can be invoked from another repo (eg workshop checking out that workflow)
Or to submit a plugin if you forgot to add the label on merge

Check PR body

Was already checking if PR body was not empty
Now checks if PR has a changelog section when "Submit on merge" label is present
NOTE: The PR template was updated to require a changelog heading by default.

Pre merge Checklist

Set up development and production environments in framer/plugins CI and configure secrets and env variables
Change development to production in CI jobs after QA
Update Slack workflow to post to #team-plugins instead of #test

Testing

Please test in the fork to test the PR workflow: niekert/plugins.

LMK when you start QA I will give you full repo permissions.

niekert · 2026-02-05T13:04:37Z

.github/workflows/submit-on-merge.yml

+      github.event.pull_request.merged == true &&
+      contains(github.event.pull_request.labels.*.name, 'Submit on merge')
+    # FIXME: Should be production
+    environment: development


note to self to fix before merging.

niekert · 2026-02-05T13:05:24Z

.github/workflows/submit-on-merge.yml

+          ERROR_WEBHOOK_URL: ${{ secrets.ERROR_WEBHOOK_URL }}
+          RETOOL_URL: ${{ secrets.RETOOL_URL }}
+          # FIXME: Should be production
+          FRAMER_ENV: development


niekert · 2026-02-05T13:13:35Z

scripts/submit-plugin.ts

+const SubmissionResponseSchema = v.object({
+    version: v.number(),
+    // FIXME: THIS SHOULD BE DEPLOYED:
+    // SEE: https://github.com/framer/creators/pull/2487/files


note to self: remove the fallback

niekert · 2026-02-05T14:04:36Z

@cursor review

niekert · 2026-02-05T14:05:13Z

/gemini review

niekert · 2026-02-05T14:05:31Z

@codex review

chatgpt-codex-connector · 2026-02-05T14:05:38Z

To use Codex here, create a Codex account and connect to github.

niekert · 2026-02-05T14:07:51Z

@codex review

cursor

Cursor Bugbot has reviewed your changes and found 3 potential issues.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

Comment @cursor review or bugbot run to trigger another review on this PR

cursor · 2026-02-05T14:11:11Z

.github/workflows/submit-on-merge.yml

+      github.event.pull_request.merged == true &&
+      contains(github.event.pull_request.labels.*.name, 'Submit on merge')
+    # FIXME: Should be production
+    environment: development


Development environment hardcoded instead of production

High Severity

The workflow has environment: development and FRAMER_ENV: development hardcoded with FIXME comments. The PR notes explicitly state "note to self to fix before merging." If merged as-is, all plugins submitted via the "Submit on merge" flow would go to the development environment instead of production.

Additional Locations (1)

.github/workflows/submit-on-merge.yml#L61-L62

packages/plugin-tools/src/build-and-zip.ts

cursor · 2026-02-05T14:11:11Z

.github/workflows/shippy.yml

+            package.json
+            yarn.lock
+            .yarnrc.yml
+            .yarn


Sparse checkout missing required .tool-versions file

High Severity

The sparse checkout configuration does not include .tool-versions, but the Setup Node.js step on line 51 requires this file via node-version-file: .tool-versions. The workflow will fail because the file won't exist after the sparse checkout completes.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cfb070c03c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

scripts/submit-plugin.ts

.github/workflows/submit-plugin.yml

- Add GitHub Actions workflows for plugin submission - Add scripts for validating PR body and submitting plugins - Add test:scripts command and related dev dependencies - Update PR template

niekert · 2026-02-11T10:01:29Z

.github/workflows/shippy.yml

+          node-version-file: .tool-versions
+
+      - name: Validate PR body
+        run: yarn dlx tsx scripts/validate-pr-body.ts


The dlx tsx is a lil unfortunate but I didn't want to install all workspace dependencies for this small script.

Would it be better to make scripts/ a separate package (ci-scripts) and have a only focused dependencies?

niekert commented Feb 5, 2026

View reviewed changes

niekert force-pushed the main branch 2 times, most recently from 2975293 to cfb070c Compare February 5, 2026 14:03

cursor bot reviewed Feb 5, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Feb 5, 2026

View reviewed changes

scripts/submit-plugin.ts Outdated Show resolved Hide resolved

.github/workflows/submit-plugin.yml Show resolved Hide resolved

niekert force-pushed the main branch 8 times, most recently from efb8561 to 1abd9e6 Compare February 6, 2026 16:13

Add plugin submission workflow and GH integrations

a00f051

- Add GitHub Actions workflows for plugin submission - Add scripts for validating PR body and submitting plugins - Add test:scripts command and related dev dependencies - Update PR template

niekert force-pushed the main branch from 1abd9e6 to a00f051 Compare February 6, 2026 16:32

niekert added 3 commits February 6, 2026 17:39

environment boolean flag

8242fab

add .tool-versions to sparse checkout

6a29ed4

up the pagination limit just to be sure

d905a9a

niekert force-pushed the main branch from 6895f88 to d905a9a Compare February 6, 2026 16:52

niekert commented Feb 11, 2026

View reviewed changes

Add CI for submitting plugins to Marketplace on merge #548

Are you sure you want to change the base?

Add CI for submitting plugins to Marketplace on merge #548

Uh oh!

Conversation

niekert commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Submit on Merge

Submit Plugin

Check PR body

Pre merge Checklist

Testing

Uh oh!

niekert Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

niekert Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

niekert Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

niekert commented Feb 5, 2026

Uh oh!

niekert commented Feb 5, 2026

Uh oh!

niekert commented Feb 5, 2026

Uh oh!

chatgpt-codex-connector bot commented Feb 5, 2026

Uh oh!

niekert commented Feb 5, 2026

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Feb 5, 2026

Choose a reason for hiding this comment

Development environment hardcoded instead of production

Uh oh!

Uh oh!

cursor bot Feb 5, 2026

Choose a reason for hiding this comment

Sparse checkout missing required .tool-versions file

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

niekert Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

niekert commented Feb 5, 2026 •

edited

Loading

niekert Feb 5, 2026 •

edited

Loading