Skip to content

Conversation

@madebyisaacr
Copy link
Collaborator

@madebyisaacr madebyisaacr commented Feb 11, 2026

Description

This pull request updates framer-plugin-tools to insert a file named framer-plugin-packed.txt into the generated plugin.zip file. This is the first step of https://github.com/framer/creators/issues/2008

If a file named framer-plugin-packed.txt exists in the /dist folder it will be overwritten.

Slack: https://framer-team.slack.com/archives/C06L5H5ADK2/p1770746299070489

Testing

  • Use yarn run pack to pack a plugin
  • In finder/file explorer, double click the plugin.zip to open it
  • Verify that a file named framer-plugin-packed.txt exists with true as the only content inside.

@madebyisaacr madebyisaacr requested a review from niekert February 11, 2026 18:47
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Comment @cursor review or bugbot run to trigger another review on this PR


const zip = new AdmZip()
zip.addLocalFolder(distPath)
zip.addFile("framer-plugin-packed.txt", Buffer.from("true", "utf-8"))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dist folder file can shadow injected marker file

Low Severity

If the plugin's dist directory already contains a file named framer-plugin-packed.txt, addLocalFolder adds it first, then addFile appends a duplicate entry. AdmZip's getEntry returns the first match, so the dist folder's version would shadow the injected marker. This silently defeats the purpose of the marker file since consumers reading the zip would get the wrong content.

Fix in Cursor Fix in Web

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Now if a file named framer-plugin-packed.txt exists in the /dist folder it will be overwritten.

Copy link
Member

@niekert niekert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one 👏

@madebyisaacr madebyisaacr added this pull request to the merge queue Feb 12, 2026
Merged via the queue into main with commit 84a48b7 Feb 12, 2026
8 of 10 checks passed
@madebyisaacr madebyisaacr deleted the plugin-tools-inject-file branch February 12, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants