Fix signifiers getting wrapped twice - #4
Open
davidstosik wants to merge 1 commit into
Open
davidstosik wants to merge 1 commit into
davidstosik wants to merge 1 commit into
Conversation
See frankolson#3 for details. Basically, the `.task-list-item` selector will select HTML elements that were already selected by `ul > li`. Combining them both into `renderedBullets` duplicated checkbox items. In my changes, I query the DOM only once for all `ul > li` items, then use filtering to find inside these items the ones that are actually checkboxes.
|
Thanks @davidstosik — your diagnosis of the selector overlap was spot-on. I've just been through #3 in depth and my fork's v1.3.1 takes a slightly wider approach: same selector fix, plus the |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #3 for details.
Basically, the
.task-list-itemselector will select HTML elements that were already selected byul > li.Combining them both into
renderedBulletsduplicated checkbox items.In my changes, I query the DOM only once for all
ul > liitems, then use filtering to find inside these items the ones that are actually checkboxes.