Repository navigation
fix(tunnel): preserve owned tasks through heartbeat write failures - #5
Draft
franksong2702 wants to merge 2 commits into
Draft
franksong2702 wants to merge 2 commits into
franksong2702 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport upstream #1411,
6d50934b451c9a524cf9077dbc67656c2a8e5129, unchanged onto maintained8340dd0f. Preserves fork-specific patches.Heartbeat publication failures retain the owned Tunnel and retry at normal cadence, without restart/replay. Initial publication, ACL/locks, seven-second freshness, shutdown and actual task failure remain unchanged.
Validation: formatting, Markdown links, diff-check and 43 CI ownership/path-risk tests passed. Independent static review found no blocker. Local Rust tests could not execute: required atomic-waker 1.1.2 absent from cache and download rejected HTTP 403 by cloud network policy. Exact-head CI is required before merge; draft pending verification. No native/real Host acceptance claimed.
Evidence. Published tree
71bcb48ab202527d572d1e48c6ddf14d6ac0cc33exactly matches local candidate.No deployment, release, proxy configuration, permission change, service restart or upstream PR. PR #2 remains separate.
Follow-up head
d96430ed8c908eb6b10a7a715858c7bda48122da: first CI passed Linux Rust and Windows heartbeat tests (1+3), but tooling/contract failed on unchanged fixture output-directory assumptions after CI upgraded to Rust 1.100.0. Test-only fix now locates output using Cargo JSON while preserving unique artifact, package identity, stable path and all mtime/dirty-state assertions. Independent delta review and all 6 local build-identity tests passed on 1.99.1. Exact new-head CI still required. Updated evidence.