Conversation
Extend Dark Mode from a toggle to OFF / ON + Images / ON, greyscale-inverting ebook images so white backgrounds no longer appear as boxes.
Solidify inverted AA greys to white and skip the image greyscale pass so flourishes and line art keep continuity without a noisy e-ink halo.
Keep ON + Images on the EPUB DirectPixelWriter path and stop inverting UI BMPs such as covers, sleep images, and stats thumbnails.
Limit ON + Images invert to short landscape assets that are very wide or reused, so general artwork stays uninverted.
(i.e. don't redefine "ON", compose via STR_STATE_ON + " + " STR_STATE_ON_DIVIDERS)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What is the goal of this PR?
Broadly speaking, the images I encounter reading ebooks tend to be either be full-page art of some kind or separators (i.e. glorified
----). Full-page art is fine, but separators look pretty bad with dark mode on, since they tend to have a white background rather than a transparency (or at least, that's how they render in CrossPoint). So when the intent was to have an ornate/calligraphic separator, you instead see a white rectangle with a barely-visible dark separator (since they're generally thin lines).This PR adds a third option to the Dark Mode toggle for "ON + Separators" that inverts non-fullscreen ebook images.
What changes are included?
Dark mode now has 3 states:
OFF,ON + Dividers, orON. The new middle option detects images that are wide-but-short AND are repeated more than once in a book, and inverts the imageAdditional Context
AI Usage
While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.
Did you use AI tools to help write this code? < YES >