fix(database): Sync prefixlen of FTS index during restoration#459
Open
tanmoysrt wants to merge 1 commit intofrappe:developfrom
Open
fix(database): Sync prefixlen of FTS index during restoration#459tanmoysrt wants to merge 1 commit intofrappe:developfrom
tanmoysrt wants to merge 1 commit intofrappe:developfrom
Conversation
c2e92de to
6d2eef3
Compare
6d2eef3 to
711eb09
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a schema mismatch error during database restoration by ensuring FTS (Full-Text Search) index prefix lengths are properly synchronized from backup metadata. The issue occurs because MariaDB validates that FTS indexes are recreated using the same method (inline vs ALTER) as the original, which is tracked via the prefixlen field in .cfg files.
Changes:
- Added a binary parser to extract FTS index prefix length metadata from MariaDB
.cfgfiles - Modified the restoration workflow to collect FTS metadata and recreate indexes with correct prefix lengths when needed
- Added test coverage for the
.cfgfile parser
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| agent/utils.py | Implements binary parser for extracting FTS index prefix lengths from .cfg files |
| agent/tests/test_cfg_parser.py | Adds unit test validating the parser correctly extracts FTS index metadata |
| agent/database_physical_restore.py | Integrates FTS metadata collection and index synchronization into the restoration workflow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f26bd11 to
78fc10a
Compare
The fix has been made to fix the following issue: (1808, "Schema mismatch (Index ft_description field description prefix len 0 doesn't match metadata file value 1)) Check PR description or code inline comments for more info
78fc10a to
f4d89f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have started getting this error message while restoring tables with FTS Index :
Root Cause :
MariaDB has some special validation in place for FTS index. It really matters, how the FTS index was added in the database at first place. If we don't follow the same flow to re-create FTS, it will panic.
For example, If we add
FTS IndexviaALTERand take physical backup of the databaseWe can't restore the tablespace ever, if we have created the target table with FTS index with the following syntax
SHOW CREATE TABLE .....will always include FTS Index Creation regardless how it was added.Solution :
The
prefixlenmetadata is available inside the.cfgfile only (which generates during tablespace export). So, we have to parse the cfg file.Source : https://github.com/MariaDB/server/blob/d755574c47f101917aee29ea847e214c24c92c0b/storage/innobase/row/row0import.cc#L2816
So, if the FTS indexes prefixlen is
1according to.cfgfile, we have to drop the FTS index and re-create usingalter.