fix(atlas): Restore the provider pool prefix when an IPv6 router is archived - #308
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Archive on an IPv6 Router Server with a provider pool fails with "A direct provider pool cannot be divided into smaller allocations."
Summary
Archive now sets the allocation prefix length of a provider pool back to the pool prefix length when it removes the gateway. The pool is then a valid direct pool again.
Why
Router creation sets the pool allocation prefix length to 128 for routed allocations. Archive removed the gateway but kept 128, and a direct provider pool must allocate its whole prefix.
What changed
IPv6RouterServer.archiverestores the allocation prefix length of a provider pool.