Skip to content

fix: resolve text block bubble menu color picker positioning, slider drag, and popup layout - #694

Closed
SmrutiSawant wants to merge 5 commits into
frappe:developfrom
SmrutiSawant:color-picker-position
Closed

fix: resolve text block bubble menu color picker positioning, slider drag, and popup layout#694
SmrutiSawant wants to merge 5 commits into
frappe:developfrom
SmrutiSawant:color-picker-position

Conversation

@SmrutiSawant

Copy link
Copy Markdown
Contributor

Summary of Changes

Fixes positioning and interaction issues with the text editor's TextBlockBubbleMenu color picker:

  • Position Stability: Anchors bubble menu coordinates relative to the text editor element
  • Slider Dragging: Hue and Alpha sliders can be dragged smoothly without being blocked by parent toolbar event handlers.

Before:

Before.mp4

After:

After.mp4

@greptile-apps

greptile-apps Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 4/5

The core positioning and drag fixes look correct, but the shouldShow guard can still dismiss the color picker if selection collapses while it is open.

The shouldShow function places settingColor.value after an early return that fires when there is no text selection. A collapsed selection while the picker is open still closes the bubble menu, meaning the slider-drag fix is not fully robust.

frontend/src/components/TextBlockBubbleMenu.vue — the shouldShow callback ordering

Reviews (3): Last reviewed commit: "Update frontend/src/components/TextBlock..." | Re-trigger Greptile

Comment thread frontend/src/components/Controls/ColorPickerContent.vue Outdated
Comment thread frontend/src/components/TextBlockBubbleMenu.vue Outdated
SmrutiSawant and others added 2 commits July 24, 2026 19:39
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Comment thread frontend/src/components/TextBlockBubbleMenu.vue Outdated
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Comment thread frontend/src/components/TextBlockBubbleMenu.vue
@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.88%. Comparing base (f16bae0) to head (bbab116).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #694   +/-   ##
========================================
  Coverage    56.88%   56.88%           
========================================
  Files           35       35           
  Lines         4217     4217           
========================================
  Hits          2399     2399           
  Misses        1818     1818           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@stravo1

stravo1 commented Jul 24, 2026

Copy link
Copy Markdown
Member

The main issue was that the TextBlockBubbleMenu was hidden after losing focus when the user clicked the ColorPicker. A more concise fix was to keep it open while the ColorPicker remained focused.

The Autocomplete for the ColorPicker also jumped to the corner of the screen. Both issues have been fixed in: #695

@stravo1 stravo1 closed this Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants