fix: keep autocomplete lists full while filtering - #700
Merged
surajshetty3416 merged 7 commits intoJul 31, 2026
Conversation
Each getOptions implementation filtered and capped its own list. Once an item is selected the list showed no extra options. Add filterOptions, which puts the matches for a query first, fills the rest of the list with the other options, and stops at 20 items. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Reviews (8): Last reviewed commit: "fix: window color variable options aroun..." | Re-trigger Greptile |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #700 +/- ##
========================================
Coverage 57.59% 57.59%
========================================
Files 35 35
Lines 4271 4271
========================================
Hits 2460 2460
Misses 1811 1811 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The default font list took whatever the user font list left over. Non-matching user fonts fill that list, so 20 or more user fonts used the whole limit. A default font that matched the query never reached the dropdown. Each list now filters against its own limit.
surajshetty3416
requested changes
Jul 29, 2026
surajshetty3416
left a comment
surajshetty3416
left a comment
Member
There was a problem hiding this comment.
@stravo1 I don't this selected option should be first... it should be at its place following the sequence but checked/highlighted
filterOptions now takes limit and windowRadius in one options object. Without windowRadius it keeps the matches first, then fills the rest of the list. With windowRadius it keeps each match at its original position and shows the options around it. Only the font family list passes windowRadius. The color picker, the css keyword list, the analytics filters, the visibility input, and the dynamic value dropdown keep their current behavior.
filterOptions kept matches in place only when a caller passed a radius, and each caller had to tune the upper and lower halves itself. Now every caller gets the same window: a limit-sized slice with the match a third of the way down, so its neighbours stay visible. Color variables come from the store newest-first, so a match had unrelated neighbours. Sort them by name before filtering. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
A partial query now returns only the matching options. An exact match, which is the selected value on focus, returns a window around the selection: up to 3 neighbours above, the rest below, clamped at both ends of the list. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Place the selection about a third of the window from the top instead of a fixed neighbour count. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
stravo1
force-pushed
the
autocomplete-fill-options
branch
from
July 30, 2026 13:06
a68c4ed to
9e56746
Compare
surajshetty3416
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each
getOptionsimplementation filtered and capped its own list. Once an item was selected the list showed no extra options.Add
filterOptions, which puts the matches for a query first, fills the rest of the list with the other options, and stops at the limit. This way some options other than the selected one stay visible when available.filterOptionstakeslimitandwindowRadiusin one options object. WithoutwindowRadiusit keeps the matches first, then fills the rest of the list. WithwindowRadiusit keeps each match at its original position and shows the options around it.Before:
Screen.Recording.2026-07-28.at.6.19.38.PM.mov
After:
Screen.Recording.2026-07-28.at.6.19.10.PM.mov