fix: call take_backup instead of take_backups_s3 from JS to ensure async execution#16
Open
gajjug004 wants to merge 1 commit into
Open
fix: call take_backup instead of take_backups_s3 from JS to ensure async execution#16gajjug004 wants to merge 1 commit into
gajjug004 wants to merge 1 commit into
Conversation
gajjug004
force-pushed
the
fix/s3-backup-async-enqueue
branch
from
6f62abb to
6b5e5d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The JS form was calling
take_backups_s3directly viafrappe.call, which runsthe backup synchronously within the HTTP request. This causes a request timeout
for large backups since the connection is held open until the backup completes.