Skip to content

Comments

chore: Add support for Python 3.14#4962

Open
adityahase wants to merge 14 commits intodevelopfrom
python-314
Open

chore: Add support for Python 3.14#4962
adityahase wants to merge 14 commits intodevelopfrom
python-314

Conversation

@adityahase
Copy link
Member

@adityahase adityahase commented Feb 6, 2026

Chose Ansible 11 because templating issues.

Important: The ansible-core 2.19/Ansible 12 release has made significant templating changes that might require you to update playbooks and roles

Resolves #4886

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

❌ Patch coverage is 61.11111% with 14 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@270ce57). Learn more about missing BASE report.
⚠️ Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
...ress/press/doctype/deploy_candidate/cache_utils.py 0.00% 10 Missing ⚠️
...cture/doctype/ssh_access_audit/ssh_access_audit.py 60.00% 2 Missing ⚠️
.../doctype/deploy_candidate/test_deploy_candidate.py 0.00% 1 Missing ⚠️
press/press/doctype/log_counter/log_counter.py 66.66% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (61.11%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #4962   +/-   ##
==========================================
  Coverage           ?   50.43%           
==========================================
  Files              ?      849           
  Lines              ?    68740           
  Branches           ?      283           
==========================================
  Hits               ?    34668           
  Misses             ?    34044           
  Partials           ?       28           
Flag Coverage Δ
dashboard 72.86% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@belal-bh
Copy link

Hi @adityahase
Thank you for this PR. Python 3.14 is being used in other frappe app and press should be aligned with those. Can you look into the 2 failing check of the PR ?
I am new at frappe framework and trying to understand it slowly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add support for Python 3.14

2 participants