Skip to content

Comments

fix(signup): To avoid lock wait timeout error during signup#5280

Merged
Bowrna merged 2 commits intofrappe:developfrom
Bowrna:avoid_lock_waittimeout_signup
Feb 25, 2026
Merged

fix(signup): To avoid lock wait timeout error during signup#5280
Bowrna merged 2 commits intofrappe:developfrom
Bowrna:avoid_lock_waittimeout_signup

Conversation

@Bowrna
Copy link
Contributor

@Bowrna Bowrna commented Feb 24, 2026

Getting preferred site can return same site for concurrent signups causing issue. Added for_update and skip_locked to ensure we don't pick same site and reduced the limit to less number too

@Bowrna Bowrna changed the title Avoid lock wait timeout signup fix(signup): To avoid lock wait timeout error during signup Feb 24, 2026
@Bowrna Bowrna marked this pull request as ready for review February 24, 2026 07:51
@Bowrna Bowrna requested a review from balamurali27 as a code owner February 24, 2026 07:51
@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.50%. Comparing base (3e0501b) to head (b6b318e).
⚠️ Report is 34 commits behind head on develop.

Files with missing lines Patch % Lines
press/press/doctype/site/site.py 50.00% 1 Missing ⚠️
press/saas/doctype/product_trial/product_trial.py 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (33.33%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5280      +/-   ##
===========================================
- Coverage    50.51%   50.50%   -0.01%     
===========================================
  Files          847      847              
  Lines        69050    69049       -1     
  Branches       275      275              
===========================================
- Hits         34880    34876       -4     
- Misses       34149    34152       +3     
  Partials        21       21              
Flag Coverage Δ
dashboard 72.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Bowrna Bowrna merged commit 42fbd86 into frappe:develop Feb 25, 2026
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant