Repository navigation
fix: the frontend button opens whichever listed frontend is running - #151
Merged
Merged
Conversation
|
Preview build ready for Installs as Orca Preview, beside your normal Orca. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The top bar's frontend button only looked at the first
dev-urlsentry whose label contains "frontend", and showed nothing if that one wasn't running. With "Frontend dev server" listed before "Frontend prebuild", a running prebuild was never picked.pickFrontendPortLabelnow takes the first entry containing "frontend" whose port is live, sodev-urlsorder still sets priority when several run. Unchanged: nothing shows when no frontend is running, and the first entry is still the fallback when no label mentions a frontend.