Open
Conversation
Moved the hardcoded directory to at least C;\temp so the chance of overwriting existing files is reduced. Perhaps a check for existing directores before wiping data would be advised.
Contributor
|
Did you confirm that the path was short enough to build qt using vcpkg? |
Author
|
Can't confirm as can't complete build due to other build errors. Perhaps a better PR would be a simple I notice some other build scripts also hard code C:\B which is unfortunately a preexisting folder on my system for other things requiring a short path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved the hardcoded directory to at least C;\temp so the chance of overwriting existing files is reduced. Perhaps a check for existing directores before wiping data would be advised.