Open
Conversation
This still has several flaws: - completely untested on Windows - Standalone doesn't work on macOS either - uses CPM to get fmt when we already vendor it, cause otherwise the program doesn't link - all the metadata going into AU needs to be removed once it's read from the CLAP. This should happen before this gets merged Needs to be discussed: - replace OS APIs with std::filesystem at the expense of bumping min macOS version to 10.15?
Author
|
The error when building standalone: Is it even possible to wrap a CLAP plugin into a single portable standalone binary on Windows? If not, do we even want to support this from the CLI? |
CrushedPixel
commented
Oct 10, 2024
CrushedPixel
commented
Oct 10, 2024
CrushedPixel
commented
Oct 10, 2024
Collaborator
|
OK so a couple of things looking
so let me pull this branch down now and see if i can fix that and push up a diff or two to get you started. |
1. Make fmt work from the vendored fmt 2. Add the cmake flags so we can use std::filesystem back to 10.13 in the fs::space and modify the create_directories to use a path at least 3. Vendor in CLI11
- Also use fs for all path related activities
Author
|
At this point, I believe what's left to do is:
Please let me know if there's any more work to do. |
baconpaul
reviewed
Oct 11, 2024
Collaborator
baconpaul
left a comment
baconpaul
left a comment
There was a problem hiding this comment.
Some comments on a quick morning skim
| else() | ||
| add_custom_command(TARGET ${VST3_TARGET} POST_BUILD | ||
| COMMAND ${CMAKE_COMMAND} -E copy_directory | ||
| "${OUTPUT_DIR}/${PROJECT_NAME}.vst3" |
Collaborator
There was a problem hiding this comment.
This can't work right? IT copies from nowhere to the output dir?
Author
There was a problem hiding this comment.
Whoops. Should be fixed now, but requires some testing on Windows, so I won't resolve convo yet
baconpaul
reviewed
Oct 11, 2024
CrushedPixel
changed the title
|
Testing the CLI with Linux Mint 22 shows two issues when building a VST3:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT PR. DO NOT MERGE. DISCUSSION REQUIRED.Any feedback is welcome.
This still has several flaws:
Standalone doesn't work on macOS eitherStandalone is unsupported atm as we can't build it into single files on all platforms.uses CPM to get fmt when we already vendor it, cause otherwise the program doesn't linkall the metadata going into AU needs to be removed once it's read from the CLAP. This should happen before this gets mergedNeeds to be discussed:
replace OS APIs with std::filesystem at the expense of bumping min macOS version to 10.15?